Add 4 new questions to GitHub Foundations around GitHub administration based on Microsoft Learn guides and GitHub official documentation.

FidelusAleksander / ghcertified

Prepare for GitHub Certification exams!

https://ghcertified.com/

MIT License

433 stars 146 forks source link

Add 4 new questions to GitHub Foundations around GitHub administration based on Microsoft Learn guides and GitHub official documentation. #209

Closed JBonifacio closed 7 months ago

JBonifacio commented 8 months ago

PR Type

[x] Adding new question(s)

Warning: We do not support the inclusion of questions directly copied from official GitHub certification exams. Please only submit original questions and content that you have created.
[ ] Other content changes (updating questions, answers, explanations or study resources)
[ ] Code changes (non-content)
[ ] Documentation changes
[ ] Other

What's new?

Added 4 new questions for Foundations exam for administration.

JBonifacio commented 8 months ago

I am studying for the foundations exam - writing questions helps me with knowledge retention. Hope this helps the repo.

rilindo commented 8 months ago

@JBonifacio There are some words that are mis-spelled, which is why the tests are failing. Can you correct these?

FidelusAleksander commented 8 months ago

Hi @JBonifacio - Thanks for raising the PR!

I am not able to fully review this right now, however on a first glance there are quite a few typo's and things to fix.

You can try self review and update this PR yourself (start with what's failing in PR checks), or I will fully review it tomorrow or the day after :smiley:

JBonifacio commented 8 months ago

I will first start with correcting the misspellings then 👍🏽

JBonifacio commented 8 months ago

Looks good to go, will likely add more questions now that I have a good idea of this merge process. Thanks for commenting.

JBonifacio commented 7 months ago

Went through the comments. I will say that I am a little embarrassed by the number of issues you two pointed out but it helps me reinforce the learning. I will try to be more accurate and in-line with your suggestions in future pull requests so I don't waste as much of your time.

I definitely feel out of my element since I wanted to try using codespaces instead of my local to learn while contributing.

It looks like the abbreviation TOTP is rejected from the pr-check.

FidelusAleksander commented 7 months ago

Thanks for the fixes @JBonifacio !

Don't worry about the amount of comments, I'm quite nit picky myself but I want these practice tests to be considered of high quality.

I will do a final review in a bit, for the cspell issue can you add the missing abbreviation in cspell.json please ?

FidelusAleksander commented 7 months ago

Hi @JBonifacio

Are you planning on continuing work on this PR?

JBonifacio commented 7 months ago

Hi @JBonifacio

Are you planning on continuing work on this PR?

Sorry, was caught up at some triage last week at work. I'll resolve your comments today!

JBonifacio commented 7 months ago

Thanks @FidelusAleksander - I actually passed my exam this weekend, and now my (actual) goal is the GitHub actions exam. I'll try to keep the mistakes I did here in mind and will contribute again soon.