search

Field-Effect-LLC / RDP-BattMon

A Microsoft RDP Client (MSTSC) Plugin to Report Device Battery Life
33 stars 7 forks source link

Percentage reported over 100% #19

Open peterberbec opened 6 years ago

peterberbec commented 6 years ago

image

I'm not sure how this came about.

transistor1 commented 6 years ago

Wow... does it correct itself over time or has it consistently been off?

peterberbec commented 6 years ago

I just tried to check. I turned off wifi on the rdp machine, to get a better connection. Didn't know the network cable was unplugged. whoops.

I'll check when I get home

peterberbec commented 6 years ago

This is a new issue, I hadn't seen it before. I watched it all the way up to full charge. Once the laptop was full, i believe it was at 112%

transistor1 commented 6 years ago

I will also need you to turn on logging on client & server, which is described on the Readme of the Dev branch... but I can’t recall if any of the posted releases have logging enabled or not. If logging doesn’t work for the build you’re using, I will post a new build later this evening On Thu, Mar 15, 2018 at 1:11 PM Peter Berbec notifications@github.com wrote:

This is a new issue, I hadn't seen it before. I watched it all the way up to full charge. Once the laptop was full, i believe it was at 112%

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Field-Effect-LLC/RDP-BattMon/issues/19#issuecomment-373453112, or mute the thread https://github.com/notifications/unsubscribe-auth/AFXWEHfnJonMr2SrgHiKUkNVNKt_d_OWks5teqDMgaJpZM4Sp3pg .

--

Sent from my phone

peterberbec commented 6 years ago

It's back to normal.

I'm using the 1.0.2 release. I enabled logging per README.md and if it happens again, will post relevent info.

image

peterberbec commented 6 years ago

Honestly, I'll probably just leave logging on. It seems I'm QA, so that'll help in the future!

transistor1 commented 6 years ago

Any luck reproducing this? If yes, I'd like to see the logs (preferably with v1.0.2.2-- v1.0.2 didn't have logging set up completely). I suspect that WMI was/is reporting the battery over 100%; if WMI is misreporting the data, there's probably not much we can do; though I do have a couple of thoughts:

Both use cases are another reason for the loose coupling: to implement a different method of battery data collection, we simply create a new class that implements IBatteryDataCollector, and allow the user to choose which implementation to use. That can probably be configured at the Ninject level, where the concrete classes are bound.

peterberbec commented 6 years ago

Haven't seen it since that day, btw.

transistor1 commented 6 years ago

Ok we will leave the issue open and keep an eye out for it. Hopefully we can get some more information.

On Sat, Mar 24, 2018 at 7:52 PM Peter Berbec notifications@github.com wrote:

Haven't seen it since that day, btw.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Field-Effect-LLC/RDP-BattMon/issues/19#issuecomment-375933542, or mute the thread https://github.com/notifications/unsubscribe-auth/AFXWEHjkiZdr9evFzZy5781U09tHZGFEks5thtwggaJpZM4Sp3pg .

--

Sent from my phone