search

Field-Robotics-Lab / dave

Project DAVE
Apache License 2.0
224 stars 72 forks source link

Update repo name and location for acoustic messages #269

Closed rolker closed 10 months ago

rolker commented 1 year ago

This addresses #268.

lauralindzey commented 1 year ago

In order to future-proof this, you may want to use a specific tag or commit for the marine_msgs repo, rather than having it use main.

mabelzhang commented 1 year ago

Might fix errors like this one on acoustic_msgs https://github.com/Field-Robotics-Lab/dave/issues/272 But the package names in hydrographic_msgs have also been changed, right? So acoustic_msgs are no longer that, it has to be changed to marine_acoustic_msgs now?

😅 I got confused in that issue, because now there's another package that's been released and called acoustic_msgs 😅 and that one had a genuine error that we ran into a few weeks back. It could get very confusing for somebody.

Is marine_msgs still for Noetic? I ask because that's what DAVE targets. If you will have different branches, it would also help if we can use the Noetic one here.

I don't have a setup to test it anymore. I don't know if anybody has at this point. So I don't know if we'll be merging PRs. (I could try to make time, but no guarantees.)

lauralindzey commented 1 year ago

@mabelzhang -- just a note that I'm at sea, and will be getting home late August. I tried (and failed) to get marine_acoustic_msgs properly released before I left, so it's close to the top of my stack for when I get home.

But the package names in hydrographic_msgs have also been changed, right? So acoustic_msgs are no longer that, it has to be changed to marine_acoustic_msgs now?

Correct.

mabelzhang commented 1 year ago

Thanks for the quick reply!

I wonder if you could create stub packages with the old name, and have package.xml that install the new packages. That way, it is backward compatible and won't break people who have been using the APL repo. For example, upstream, we had to change the names for a lot of packages during the Ignition->Gazebo rename, and that could have broken a lot of people. But we did it in a way that didn't.

(Not that I'm making a selfish suggestion because we aren't actively maintaining this repo 😅 )

mabelzhang commented 10 months ago

Ooh that's a good idea. I think maintainers (you) can probably push to the branch? If you want to just push that and merge.