search

Field-Robotics-Lab / dave

Project DAVE
Apache License 2.0
229 stars 69 forks source link

Where are the Virgil files that are used to new underwater vehicle tutorial? #270

Open whoi-engineer opened 1 year ago

whoi-engineer commented 1 year ago

I've tried following the new underwater vehicle tutorial but I am hitting roadblocks. The tutorial would be easier to follow and then modify with ones own vehicle if the documents for the tutorial were actually on git. Is there something I'm missing? There are also parts of the tutorial that I believe are no longer supported. For example: ` <xacro:thruster_module_first_order_basic_fcn_macro namespace="$(arg namespace)" thruster_id="${thruster_id}" x_axis="0" y_axis="0" z_axis="1" mesh_filename="${prop_mesh_file}" dyn_time_constant="0.05" rotor_constant="0.00031">

    </xacro:thruster_module_first_order_basic_fcn_macro>
</xacro:macro>`

if you include the parameters x_axis="0" y_axis="0 z_axis="1" then when you launch it tells you invalid parameters.

mabelzhang commented 1 year ago

if the documents for the tutorial were actually on git

Are you referring to the tutorials for this repo? It is on Git: https://github.com/Field-Robotics-Lab/dave.doc (the GitHub repo name for GitHub IO pages are usually the last part of the URL)

mabelzhang commented 1 year ago

Answering the title of the issue, the virgil files I believe are in a PR https://github.com/Field-Robotics-Lab/dave/pull/244

It was one of the last PRs for the project, and the project has since been out of funding. The PR has gone through a long review as you can see. Feel free to give it a try.