Field-Robotics-Lab / dave

Project DAVE
Apache License 2.0
227 stars 71 forks source link

Specification of glider rigid body inertia values #46

Closed bsb808 closed 3 years ago

bsb808 commented 4 years ago

Running this command

roslaunch uuv_dave uuv_gliders_hybrid_whoi.launch paused:=true

generates a warning...

[ WARN] [1599576113.958181542]: The root link glider_hybrid_whoi/base_link has an inertia specified in the URDF, but KDL does not support a root link with an inertia.  As a workaround, you can add an extra dummy link to your URDF.

This suggests that the rigid body inertia of the vehicle may not be set.

I believe the slocum and wave glider examples have the same warning: https://github.com/Field-Robotics-Lab/dave/wiki/Glider-Models

woensug-choi commented 4 years ago

It seems this can be solved by adding following dummy joint to fix urdf format defined inertia. Will try and update.

above base_link

<link name="dummy">
</link>

below base_link

    <joint name="dummy_joint" type="fixed">
      <parent link="dummy"/>
      <child link="base_link"/>
    </joint>

Besides, the inertial matrix definition is going to be recalculated by the glider dynamics plugin (which is being developed) with Fossen's theory at line where inertial matrix is calculated in the plugin.

woensug-choi commented 4 years ago

@M1chaelM @bsb808 I would say this is an intermediate error issue and not to be included as 'should be resolved before 2.0 release'.

For issue being This suggests that the rigid body inertia of the vehicle may not be set., my answer is the inertial matrix definition is going to be recalculated by the glider dynamics plugin which is being developed and will be merged with the glider vehicle models later.

Currently, the inertial definitions at urdf are required for UUV_Simulator's uuv_underwater_object_ros_plugin. The same warning msg was shown for UUV Simultor's Rexrov model demo. Regrettably, the dummy root link solution is denied by the plugin too. Unless all the plugins and sensors are stripped off for glider models, a new plugin should be used. I am working on a later solution (glider dynamics/kinematics plugins) with better dynamics for gliders targeting release 3.0.

woensug-choi commented 3 years ago

Re-summarizing this subject. Problem:

[ WARN] [1599576113.958181542]: The root link vehicle_name/base_link has an inertia specified in the URDF, but KDL does not support a root link with an inertia.  As a workaround, you can add an extra dummy link to your URDF.

Conclusion: It's complaining that the Gazebo may not understand vehicle inertial properties. But as long as the underwater object plugin of the UUV simulator is being used, the hydrodynamics properties including inertial properties are working in place. Therefore, the warning message can be and should be ignored for our cases.