woensug-choi
commented
4 years ago Effort 1 PR has already been merged. For effort 2, the plugin is being developed in the PR (https://github.com/Field-Robotics-Lab/glider_hybrid_whoi/pull/15) which makes this issue redundant.
@bsb808 I have noticed issues being added concerning required sensor implementations. The objective of this repository is for plugin developments for hybrid gliders which are to be cloned outside uuv_dave (the main dave repository). Vehicle exemplars for 3 gliders are on the PR (glider_models branch PR at dave repository) at the main dave repository as a branch (glider_models branch at dave repository) to have glider models included in dave/models and launch files waiting for initial merge.
Meanwhile, in this repository, sensors are defined at xacro file which is inherited from eca_a9 for plugin tests. It includes 3D pose sensor, DVL sensor, Side scan sonar left/right sensors, Pressure sensors, IMU sensors, GPU sensors, chemical concentration sensor and a camera sensor. glider_hybrid_whoi_sensors.xacro
@bsb808 @BruceMty Two development efforts should be merged eventually later with hybrid glider plugins later. But concerning the time limit before release 2.0, vehicle models are to be merged into the main dave project with static launch file sets. I do hope that the plugin could be added to the vehicle models before release.
I guess the issues concerning sensors requirements should be moved to the glider model branch in dave project (Effort 1). If @BruceMty can help adding sensors at the branch (again, not this repository) with issues made by brian in this repository would be great.