Field-Robotics-Lab / nps_uw_multibeam_sonar

Multibeam sonar plugin with NVIDIA Cuda library
Apache License 2.0
35 stars 20 forks source link

Build fails for current HEAD: 2b8d9bc #12

Closed lauralindzey closed 3 years ago

lauralindzey commented 3 years ago

This time, in the correct repo :-\

As the title says -- after running vcs pull my workspace no longer successfully builds.

This appears to have been recently introduced, since 28f9ca4 works for me.

The first few lines of errors when I run catkin build are:

Finished  <<< nps_uw_sensors_gazebo                       [ 11.8 seconds ]                                                            
______________________________________________________________________________________________________________________________________
Errors     << nps_uw_multibeam_sonar:make /home/lindzey/dave_ws/logs/nps_uw_multibeam_sonar/build.make.018.log                        
/home/lindzey/dave_ws/src/nps_uw_multibeam_sonar/src/gazebo_ros_multibeam_sonar.cpp: In member function ‘virtual void gazebo::NpsGazeboRosMultibeamSonar::OnNewImageFrame(const unsigned char*, unsigned int, unsigned int, unsigned int, const string&)’:
/home/lindzey/dave_ws/src/nps_uw_multibeam_sonar/src/gazebo_ros_multibeam_sonar.cpp:685:33: error: ‘reflectivity_image’ was not declared in this scope; did you mean ‘reflectivityImage’?
  685 |       this->reflectivityImage = reflectivity_image;
      |                                 ^~~~~~~~~~~~~~~~~~
      |                                 reflectivityImage
/home/lindzey/dave_ws/src/nps_uw_multibeam_sonar/src/gazebo_ros_multibeam_sonar.cpp: At global scope:
/home/lindzey/dave_ws/src/nps_uw_multibeam_sonar/src/gazebo_ros_multibeam_sonar.cpp:692:6: error: ‘NpsGazeboRosMultibeamSonar’ has not been declared
  692 | void NpsGazeboRosMultibeamSonar::ComputeSonarImage(const float *_src)
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/lindzey/dave_ws/src/nps_uw_multibeam_sonar/src/gazebo_ros_multibeam_sonar.cpp: In function ‘void ComputeSonarImage(const float*)’:
/home/lindzey/dave_ws/src/nps_uw_multibeam_sonar/src/gazebo_ros_multibeam_sonar.cpp:694:3: error: invalid use of ‘this’ in non-member function
  694 |   this->lock_.lock();
      |   ^~~~

I put the full set of errors messages on pastebin.

woensug-choi commented 3 years ago

@lauralindzey It should be fixed now.

lauralindzey commented 3 years ago

Thanks! I just pulled, and it now works for me.