search

Field-Robotics-Lab / nps_uw_multibeam_sonar

Multibeam sonar plugin with NVIDIA Cuda library
Apache License 2.0
35 stars 21 forks source link

Migration to ROS2 #45

Open woensug-choi opened 2 years ago

woensug-choi commented 2 years ago

Thanks a lot for all your explanations and advice, I've finally found why the ray version wasn't working. I was using the wrong velodyne_simulator (not the official one). Everything is working fine now! By the way, I have migrated your sonar plugin to ROS2 (galactic). If you're interested, I can open a PR on a new branch dedicated to ROS2?

_Originally posted by @estellearrc in https://github.com/Field-Robotics-Lab/nps_uw_multibeam_sonar/issues/42#issuecomment-1141898306_

woensug-choi commented 2 years ago

YES! There was also someone who asked me about any plans for migration to ROS2.

May I ask you to give me some notes on ROS2 supported version? Any compatibility issues with the parent Dave repo?

estellearrc commented 2 years ago

I've migrated it to ROS2 galactic. For the compatibility issues, nothing to report except for the CUDA Toolkit library and its driver, one has to be careful on the choice of the version according to his/her material architecture as explained here. But I've written everything in the README.

On which branch can I open the PR?

woensug-choi commented 2 years ago

@estellearrc Can't you make a new branch for your PR?