search

Field-Robotics-Lab / nps_uw_multibeam_sonar

Multibeam sonar plugin with NVIDIA Cuda library
Apache License 2.0
35 stars 20 forks source link

Bug in sonar_image_raw_msg_.beam_directions #51

Closed mkolodziejczyk-piap closed 8 months ago

mkolodziejczyk-piap commented 1 year ago

Hi, I noticed that in sonar_image_rawmsg.beam_directions beam_directions are added, but never cleared. I think this is a bug

https://github.com/Field-Robotics-Lab/nps_uw_multibeam_sonar/blob/50655e529d5887e8189b217b6f0e1efd0d0c730e/src/gazebo_multibeam_sonar_raster_based.cpp#L936-L943

Regards,

woensug-choi commented 1 year ago

Does this cause memory usage explosion?

woensug-choi commented 1 year ago

Thank you for the indepth look into the code lines!

woensug-choi commented 1 year ago

This should fix it. PR https://github.com/Field-Robotics-Lab/nps_uw_multibeam_sonar/pull/52

If you can test and agree on the PR, we shall merge it!

woensug-choi commented 8 months ago

Closing it since PR is merged