FieldStudiesCouncil / QGIS-Biological-Recording-Tools

QGIS plugin for biological recorders. Created with the FSC Tomorrow's Biodiversity project.
GNU General Public License v3.0
10 stars 4 forks source link

OSGR panel doesn't handle being small #21

Open rossburton opened 6 years ago

rossburton commented 6 years ago

If the OSGR panel isn't large on MacOS then the grid reference label isn't visible, see attachment.

Looks like the widget packing needs a bit of fiddling.

screen shot 2018-06-18 at 12 08 41

burkmarr commented 6 years ago

Hi Ross. I've noticed these layout issues before on QGIS with Mac. I can't reproduce in Windows - the image below shows the interface squeezed as tightly as possible with Windows 10. The plugin GUI is built with QT Designer (version 5.9.2) and uses the standard widget layouts provided by that. What you're seeing could be an issue with QT or with QGIS or the way that QGIS handles the QT plugin interfaces - I don't know. Unfortunately I don't have access to a Mac environment or the necessary experience with QT and Mac to address this myself, but I have labelled the issue to indicate that help is wanted. Hopefully it might catch the eye of someone that can help.

image

charlesroper commented 4 years ago

@burkmarr I have reproduced this on Windows. It's due to the display having a high pixel density (aka HiDPI or Retina) and, in the case of Windows, scaling being set to >100%. Here's a screenshot of what I see when I first open the tool:

image

Aside from the squashed elements at the bottom, notice how tiny the close and restore icons are. I was able to rectify this easily by dragging the border above the widget up, so that the widget occupies more vertical space:

image

Here is a screenshot of the settings on my laptop's 2880x1620 (marketed as 3K) display:

image

I've noticed all sorts of glitches and quirks in the QGIS UI on my display, which is down to, I think, QT (or at least QGIS's use of it) not being fully adapted to high density. It's got vastly better over the last year or two, though. When I first got this laptop in 2015, QGIS was practically unusable (as were many other applications) because everything in the UI was unscaled and tiny, or scaled and blurry. These days it's the exception to find an app that doesn't work with high-density displays.

A couple of suggestions for reproducing this problem:

More about high-density displays here: https://www.eizoglobal.com/library/basics/pixel_density_4k/

burkmarr commented 4 years ago

Thanks for the analysis @charlesroper - I've just reproduced on my laptop (which I normally use with external screens so hadn't noticed). I suspect that this can be fixed by changing the QT sizing policy of the widgets in question - perhaps setting minimal sizes. I've added the bug label so that it can be dealt with next time work is done. The workaround is just to resize currently - as you saw.

I suspect that would not have fixed the problem for @rossburton at the time he reported it because at that time QGIS 2 and the plugin was with QT 4 - now QGIS 3 and the plugin use QT 5 and, as you say, things have improved.