FiendsOfTheElements / FF1Randomizer

A randomizer for Final Fantasy 1 on the NES.
http://finalfantasyrandomizer.com
GNU General Public License v3.0
82 stars 46 forks source link

Spaces replaced with + #533

Closed Trelior closed 3 years ago

Trelior commented 3 years ago

I finally came back to FFR recently and found a rather humorous, but annoying quirk in the new text modification.

FFR_6BA6CA54_gqEVHsWinq84KWkJ92 5ecKHVxGvq0CVabjOeXXgNn7FdaVcqs5eciJy5Ab56UP-LRxUxUkDpCsvo-DNumToKdvLs9Xy28D AucC-2 FFR_6BA6CA54_gqEVHsWinq84KWkJ92 5ecKHVxGvq0CVabjOeXXgNn7FdaVcqs5eciJy5Ab56UP-LRxUxUkDpCsvo-DNumToKdvLs9Xy28D AucC-3 FFR_6BA6CA54_gqEVHsWinq84KWkJ92 5ecKHVxGvq0CVabjOeXXgNn7FdaVcqs5eciJy5Ab56UP-LRxUxUkDpCsvo-DNumToKdvLs9Xy28D AucC-4 FFR_6BA6CA54_gqEVHsWinq84KWkJ92 5ecKHVxGvq0CVabjOeXXgNn7FdaVcqs5eciJy5Ab56UP-LRxUxUkDpCsvo-DNumToKdvLs9Xy28D AucC-5

I've traced the culprit to the symbol being added during the randomization here image

The only modification to my text on the my base ROM is minor spell name edits, monster names, and normalizing the capitalization on items and attacks. Being mindful that an old ROM I had no longer works, and breaks on finalizing the mod, I was careful to preserve the original blank spaces in Hackster.

Please advise. I don't want to have to manually delete the + graphic in every ROM I generate.

wildham0 commented 3 years ago

So for some reason when you modify text in FFHackster, instead of writing back the text with the space byte $FF, it writes it back with the unused character $C1. So the immediate solution right now is to either manually change the $C1 to $FF or to use another editor to modify the text. I'll see what we can do on our end.

wildham0 commented 3 years ago

Well, that was easy, should be fixed in beta now.