search

Fifteen15Studios / MMM-AutoDimmer

Magic Mirror Module to dim the screen on a schedule
MIT License
27 stars 2 forks source link

Not fully dimming #5

Closed Plainbroke closed 2 years ago

Plainbroke commented 2 years ago

@Fifteen15Studios I have maxDim set to 1.0 and it does not go fully dark as I expected. Actually, there seems to be no difference between default and the maxDim set to 1.0 { module: "MMM-AutoDimmer", position: "fullscreen_above", header: "", config: { maxDim: 1.0, schedules: [{ dimTime: 1450, brightTime: 700 }] // Uses all default values } },

Do I have something out of order or not correct at all?

Fifteen15Studios commented 2 years ago

The maxDim should be inside of the schedule. The only thing that goes into the main config is the schedules

Plainbroke commented 2 years ago

Ok that was what I needed clarified the readme doesn't really specify that. Maybe you could update the readme to show where to put the options..

Plainbroke commented 2 years ago

Thank you, that fixed the issue.

On Tue, Jul 26, 2022, 5:16 PM Fifteen 15 Studios @.***> wrote:

The maxDim should be inside of the schedule. The only thing that goes into the main config is the schedules

— Reply to this email directly, view it on GitHub https://github.com/Fifteen15Studios/MMM-AutoDimmer/issues/5#issuecomment-1196035209, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMPPR7LYXWTVK4B2RYXNONTVWBPR5ANCNFSM54XEUONA . You are receiving this because you authored the thread.Message ID: @.***>

Fifteen15Studios commented 2 years ago

Ok that was what I needed clarified the readme doesn't really specify that. Maybe you could update the readme to show where to put the options..

It does explain it in the configuration options

Plainbroke commented 2 years ago

I must have missed reading that part of the configuration. Thanks for the clarification.

On Thu, Jul 28, 2022, 9:50 PM Fifteen 15 Studios @.***> wrote:

Ok that was what I needed clarified the readme doesn't really specify that. Maybe you could update the readme to show where to put the options..

It does explain it in the configuration options

— Reply to this email directly, view it on GitHub https://github.com/Fifteen15Studios/MMM-AutoDimmer/issues/5#issuecomment-1198825846, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMPPR7NQIE2WNDQBUEAPBY3VWNBGFANCNFSM54XEUONA . You are receiving this because you authored the thread.Message ID: @.***>