FightPandemics / FightPandemics-iOS-SwiftUI

Fight Pandemics iOS App: A place to offer and request help. Pandemics will happen. We help communities prepare and respond.
4 stars 3 forks source link

Add "Feed" Component #38

Closed hank-1023 closed 4 years ago

hank-1023 commented 4 years ago
hank-1023 commented 4 years ago

Dark Mode?

Hi Scott! Currently we don't have a design for dark mode in Zeplin. What I can do is to change the color of the text to white in dark mode but I have not idea for how other colors should change. We sure need to reflect this in the product meeting and ask for a separate set of design.

Power186 commented 4 years ago

Dark Mode?

Hi Scott! Currently we don't have a design for dark mode in Zeplin. What I can do is to change the color of the text to white in dark mode but I have not idea for how other colors should change. We sure need to reflect this in the product meeting and ask for a separate set of design.

No design for dark mode needed. No separate design needed. You set the environment for light mode in ContentView and whether a user has light mode or dark mode enabled won't matter, it will show the color/design we made in the app regardless. I'll update the change and I'd be happy to show you how to do this come next meeting if you'd like. Other than that, nice work!

hank-1023 commented 4 years ago

Dark Mode?

Hi Scott! Currently we don't have a design for dark mode in Zeplin. What I can do is to change the color of the text to white in dark mode but I have not idea for how other colors should change. We sure need to reflect this in the product meeting and ask for a separate set of design.

No design for dark mode needed. No separate design needed. You set the environment for light mode in ContentView and whether a user has light mode or dark mode enabled won't matter, it will show the color/design we made in the app regardless. I'll update the change and I'd be happy to show you how to do this come next meeting if you'd like. Other than that, nice work!

Thanks Scott! The current UI looks fine on my phone under dark mode. But some of the icons probably need to be transparent and the color scheme might need to change (under dark mode). Maybe we will consider this issue in the future when everything's done! IMG_1570