Menubar regressions

[pontaoski]

After upgrading from 0.6.4 to 0.7.1, I've noticed that the global menu has regressed a lot. Instead of being the usual File Edit View configuration, it is now a weird mixture of root-level actions and menus, which causes an extremely poor experience trying to use it with a global menu. Most global menu applets were not designed for the mixture of a menubar of menus and a menubar of root-level actions. Ideally, reverting the menu to the state it was in 0.6.4 would fix most of the UX issues.

[pontaoski]

Looks like this was introduced in the same commit that caused #172

git bisect start
# good: [a92b442ef23d9458702e3442cff42da424aa893a] Bump web binding api version
git bisect good a92b442ef23d9458702e3442cff42da424aa893a
# bad: [53b35f5403f91df0c9f7d1317bcec651ad78e0a5] Merge branch 'dev'
git bisect bad 53b35f5403f91df0c9f7d1317bcec651ad78e0a5
# good: [519f63304c4175e7f86f53af20be6b1ffc0d6caa] feat: implemented the openExtensionDirectory function
git bisect good 519f63304c4175e7f86f53af20be6b1ffc0d6caa
# bad: [8875f21b1d4648b521f644118c6fe5699df86961] feat: added a context menu for copy colors in the Theme Creator
git bisect bad 8875f21b1d4648b521f644118c6fe5699df86961
# bad: [cf6011660192f526cecc28c4153c874e4f7611ce] fix: updated styles of control window buttons
git bisect bad cf6011660192f526cecc28c4153c874e4f7611ce
# good: [b410ef16e205c24f0ac2b31ed9d07a9247d76e1d] fix: update the writeFiles function
git bisect good b410ef16e205c24f0ac2b31ed9d07a9247d76e1d
# bad: [9f7d1ccf7757ce51b48c3fb8c529846da50c000a] feat: add the new project button
git bisect bad 9f7d1ccf7757ce51b48c3fb8c529846da50c000a
# bad: [77c8ce6b833be302aa3af9a12e8acb443656a646] feat: add color profile settings
git bisect bad 77c8ce6b833be302aa3af9a12e8acb443656a646
# bad: [302518e1f8fcb6e2d206f90a2a0110577f5369e9] feat: update main menu
git bisect bad 302518e1f8fcb6e2d206f90a2a0110577f5369e9
# first bad commit: [302518e1f8fcb6e2d206f90a2a0110577f5369e9] feat: update main menu

[maulaniad]

looking forward to this, blocks off all my other widgets because of the Long text and root level actions.

[ChugunovRoman]

I don't quite understand the problem described in this issue

[maulaniad]

I don't quite understand the problem described in this issue

here is an example :

as you can see it contains a lot of unnecessary menus.

whereas the expected result should look like this, just like you know 'most apps' in general :

[ChugunovRoman]

@Mameng57 I got it, thanks for the good example :) What DE is used in the example?

[maulaniad]

@Mameng57 I got it, thanks for the good example :) What DE is used in the example?

i'm using Plasma.

i don't know about Electron, but some i can confirm are working fine. others that don't follow the system's titlebar, they just hide the menu entirely (like Spotify). so yeah just like @pontaoski mentioned, it was fine before but broken after 0.7.1

[ChugunovRoman]

@pontaoski @Mameng57 The app is designed with frameless window and the menu should open when you click on the corner icon before the minimize window icon. If I figure out how to remove the menu from the system's titlebar, I will do this

[raluvy95]

Any progress?

[songhd]

+1