search

FiguraMC / Figura

Extensively customize your character with Figura!
https://modrinth.com/mod/figura
GNU Lesser General Public License v2.1
194 stars 41 forks source link

Figura Breaks Mod Nameplates #222

Open PolyframeX opened 2 months ago

PolyframeX commented 2 months ago

Bug Description

When using figura, most mods that hide nameplates will stop working, therefore causing nameplates to constantly show.

Reproduction Steps

1) Install Figura Install Amerite and equip the mask to see the bug OR Install Origins, and origins classes, and select the rogue class. Then see the bug of usernames not hiding behind walls

Log File

https://pastebin.com/Y5P65j82

Sychic commented 3 weeks ago

For more clarity, this happens due to figura essentially overwriting the vanilla renderNameTag method in the PlayerRendererMixin. In PlayerRendererMixin#renderNameTag, Figura replicates the vanilla name tag rendering process with its own additions and cancels the original method. A more compatible approach would be to separate any additions into separate injections instead of overwriting the vanilla code. This also breaks Essential's icon rendering.

LordEnder-Kitty commented 1 day ago

I believe this also breaks Simple Voice Chat's talking icons