search

FiguraMC / Figura

Extensively customize your character with Figura!
https://modrinth.com/mod/figura
GNU Lesser General Public License v2.1
253 stars 46 forks source link

[1.21][NeoForge][0.1.5 rc.1] Likely Incompatability with Occultism #241

Open V2LenKagamine opened 4 months ago

V2LenKagamine commented 4 months ago

Bug Description

Crashes in blank test instance with Occultism + dependencies and Figura 0.1.5 RC-1

Reproduction Steps

Install Blank instance of Neoforge 21.0.109 Install Occultism + dependencies Install Figura RC-1 Launch. Crash,

Log File

Log files can be located On the Occultism Github

UnlikePaladin commented 4 months ago

Figura is not referenced anywhere in the log's crash stacktrace, it quite literally says Occultism encountered an error. And please attach the log files as well here next time you open a bug.

V2LenKagamine commented 4 months ago

Yep, sorry, was not feeling to great when I posted and figured better to post it in in both parties incase I post it in the wrong one only.

UnlikePaladin commented 4 months ago

It's alright, just please do attach the log next time lol

klikli-dev commented 4 months ago

@UnlikePaladin is Figura using any mixins? The error happens during the RegisterRenderers event, and is thrown by mixin. The crash only appears if figura is installed alongside occultism, not if occultism is alone in packs. Occultism does not use any mixins and just uses the neo register renderer events "as-is".

Outside of mixins I don't see any way that figura<->occultism interactions could cause this (unless it is a neo error)

UnlikePaladin commented 3 months ago

Figura does use Mixins in a lot of places but does not touch Neo internals like RegisterRenderers at all, if the issue is only happening when both are installed then it might be encountering an error earlier and crashes when it reaches the event, so a full game log and not just the crash log would be needed

klikli-dev commented 3 months ago

@V2LenKagamine can you provide the full log?

V2LenKagamine commented 3 months ago

crash-2024-07-19_13.09.24-client.txt debug.log latest.log These should be the relevant logs for the error, This occured in an instance of JUST occultism[1.136.5](And dependents.) + Fig.[0.1.5 RC 1]

mcmeiler commented 1 month ago

Issue still persists on NeoForge 1.21.1 with Figura 0.1.5 RC3 and Occultism 1.161.3.

latest.log debug.log crash-2024-10-09_17.38.27-client.txt Should be all the relevant logs. Let me know if there is anything else you need to know.