FiguraMC / Figura

Extensively customize your character with Figura!
https://modrinth.com/mod/figura
GNU Lesser General Public License v2.1
225 stars 44 forks source link

Include port for backend SERVER_IP #245

Closed Leialoha closed 1 month ago

Leialoha commented 1 month ago

I've been working on developing the backend for Figura clients. For additional context, please refer to issue #239.

The backend setup is nearly complete, but I'm encountering a problem where the client doesn't retain the specified port. While this may not seem critical, it becomes an issue when using a server hosting service. Without proper port forwarding, which must be handled by the server host, the client is unable to access the necessary port. Specifically, the client requires port 443 to function, and currently, the mod/plugin is restricted to using only this port. This also necessitates running the application with administrative permissions.

This pull request addresses the port retention issue, allowing the mod/plugin to be used on ports other than 443. This fix will enable me to continue developing and testing the backend in a production environment.

If you would like to review the code, please refer to my repository: https://github.com/Leialoha/Figura-Backend-Server.

UnlikePaladin commented 1 month ago

While we as a team are not particularly happy with the existence of third party backends because of the risks they may entail for users, which is why FSB is being developed in house as it is safer and allows servers to function as their own backend anyway, this doesn't really change anything that significant or make something that wasn't possible before a possibility so I guess we can accept this.

Leialoha commented 1 month ago

Ah, my goal wasn't to have Figura Backend 3.0 but was to create a plugin for Figura to run on Bukkit servers. Can't wait to see the implementation you guys create and I honestly didn't know you were actively working on it.

lexize commented 1 month ago

FSB will aslo be available on Bukkit. I am trying to make it as platform independent as possible. So far planned platforms are Fabric, Forge, and Bukkit. List of platforms can get larger in future. Also we are trying to make it as extendable as possible, but yet keep it safe. If you want to learn more we have a thread in FiguraMC: https://discord.com/channels/1129805506354085959/1262676821338493019