return a clean triangulation

Fil / d3-geo-voronoi

Voronoi / Delaunay tessellations on the sphere

ISC License

229 stars 24 forks source link

return a clean triangulation #14

Closed Fil closed 5 years ago

Fil commented 5 years ago

The underlying delaunay has these fake points; we should clean the triangulation so that is only contains triangles of real points, and so that it's completely wrapped.

See https://observablehq.com/d/96343ca0e27ad9d4

Fil commented 5 years ago

fixed the points in the triangles, which fixes the notebook.

there's still some cleaning to do, but it's going to be a bit difficult:

[x] inedges;
[ ] remove fake triangles
[x] re-stitch the triangles (halfedges)

Fil commented 5 years ago

just to keep a record and because this image is #d3BrokeAndMadeArt

untitled (54)

Fil commented 5 years ago

~~My commit broke the .triangles method…~~ EDIT: it was most probably the projection introduced in https://github.com/Fil/d3-geo-voronoi/commit/4b9aee7f0bfd84cdc962f97e4dc1d2b9e001f926; reverted in https://github.com/Fil/d3-geo-voronoi/commit/f012fe519fa810e1b9e8def4de1c3e4468d455d9 because it's sucking all my energy and I can't find the solution.

Fil commented 5 years ago

Removing fake triangles is not my priority. In the current version there are 4 of them, they are cleanly labeled (pivot,pivot,pivot) and have halfedges set to -1.