search

Fil / d3-geo-voronoi

Voronoi / Delaunay tessellations on the sphere
ISC License
229 stars 24 forks source link

Add code coverage #32 #33

Closed martinfrances107 closed 3 years ago

martinfrances107 commented 3 years ago

Add a new script "npm run coverage" which appends a code coverage report to the end of the standard test result.

Fil commented 3 years ago

Definitely feels as an improvement, and I don't mind using d3-geo-voronoi as a test bed for this. But it might be nice to see if it fits the new test framework that @mbostock is envisaging in https://github.com/d3/d3/issues/3469

martinfrances107 commented 3 years ago

Thanks for drawing my attention to the more complete topic

I would be good to do this in a uniform way...

I just tried to add my "get it done hot fix" to d3-delaunay and now I understand more completely why the quick fix did not work there

a uniform approach is needed.

I need to focus on the porting to rust .. doing 3 ports at once is more than I can handle.

So I am quite happy to keep this a useful local branch on my fork of this module.... you can close this issue if you like.

Fil commented 3 years ago

The new tooling is ready https://github.com/Fil/d3-geo-voronoi/pull/35