Fil / d3-geo-voronoi

Voronoi / Delaunay tessellations on the sphere
ISC License
229 stars 24 forks source link

Adopt type=module #35

Closed Fil closed 3 years ago

Fil commented 3 years ago

follow changes in d3-format:

TODO:

martinfrances107 commented 3 years ago

I have inspected the diff ... All looks good - nothing I can see that raises alarms.

With such a large change to the plumbing... as a third party double check I can report

"The transition to the new environment is smooth all the code for me works as before."

I have been frequently running the old version on the test over the last few weeks.. and my feeling is things have gotten much faster ( with the move to Mocha)

As someone who has been generating .. lots of PR's with minor things I thought making a PR about all the variables which could be defined as const...too small to report - but I am glad to see those things elevated to the modern standards.

Last part of my review... all the text in the README.md reads smoothly

TLGTM

Fil commented 3 years ago

I'll gladly merge a change for let and const