Filadeus / windows10-in-docker

https://git.efimio.ru/efim/windows10-in-docker
2 stars 2 forks source link

please make it compaitable with heroku #1

Closed bugbounted closed 2 years ago

bugbounted commented 2 years ago

Hi Filadeus,

I'm trying to deploy this project to heroku & make changes requirements on my fork (like added heroku.yaml , app.json & put deploy button markdown on main branch readme.MD) .

but at dyno runtime , I see in app log to heroku can't found standard iso & try to download 5GB iso file & its after idle-time ended has been crashed because too large file ,

please upload your dockerfile with standard iso link included(Win10_21H2_English_x64.iso ~ 5GB) to dockerhub or any other docker mirror portals & put it as FROM ... at the first of your github main dockerfile to bypass heroku download time limit.

I'm also put dyno runtime log at below to better understand :

heroku runtime dyno log :

2022-06-23T05:28:49.114672+00:00 app[api]: Scaled to web@1:Free by user toptwitcherz@gmail.com
2022-06-23T05:29:02.830048+00:00 heroku[web.1]: Starting process with command `/bin/bash -c ./start.sh`
2022-06-23T05:29:03.801375+00:00 app[web.1]: --2022-06-23 05:29:03--  https://git.efimio.ru/efim/windows10-in-docker/raw/branch/master/isoCheck.ps1
2022-06-23T05:29:04.050442+00:00 app[web.1]: Resolving git.efimio.ru (git.efimio.ru)... 151.0.14.124
2022-06-23T05:29:04.185569+00:00 app[web.1]: Connecting to git.efimio.ru (git.efimio.ru)|151.0.14.124|:443... connected.
2022-06-23T05:29:04.651426+00:00 app[web.1]: HTTP request sent, awaiting response... 200 OK
2022-06-23T05:29:04.651463+00:00 app[web.1]: Length: 394 [text/plain]
2022-06-23T05:29:04.651604+00:00 app[web.1]: Saving to: 'isoCheck.ps1'
2022-06-23T05:29:04.651651+00:00 app[web.1]: 
2022-06-23T05:29:04.651826+00:00 app[web.1]:      0K                                                       100% 39.5M=0s
2022-06-23T05:29:04.651826+00:00 app[web.1]: 
2022-06-23T05:29:04.651869+00:00 app[web.1]: 2022-06-23 05:29:04 (39.5 MB/s) - 'isoCheck.ps1' saved [394/394]
2022-06-23T05:29:04.651869+00:00 app[web.1]: 
2022-06-23T05:29:04.655662+00:00 app[web.1]: --2022-06-23 05:29:04--  https://git.efimio.ru/efim/windows10-in-docker/raw/branch/master/launchNoVNC.sh
2022-06-23T05:29:04.658715+00:00 app[web.1]: Resolving git.efimio.ru (git.efimio.ru)... 151.0.14.124
2022-06-23T05:29:04.799532+00:00 app[web.1]: Connecting to git.efimio.ru (git.efimio.ru)|151.0.14.124|:443... connected.
2022-06-23T05:29:05.273096+00:00 app[web.1]: HTTP request sent, awaiting response... 200 OK
2022-06-23T05:29:05.273220+00:00 app[web.1]: Length: 65 [text/plain]
2022-06-23T05:29:05.273280+00:00 app[web.1]: Saving to: 'launchNoVNC.sh'
2022-06-23T05:29:05.273340+00:00 app[web.1]: 
2022-06-23T05:29:05.273822+00:00 app[web.1]:      0K                                                       100% 4.78M=0s
2022-06-23T05:29:05.273822+00:00 app[web.1]: 
2022-06-23T05:29:05.273883+00:00 app[web.1]: 2022-06-23 05:29:05 (4.78 MB/s) - 'launchNoVNC.sh' saved [65/65]
2022-06-23T05:29:05.273883+00:00 app[web.1]: 
2022-06-23T05:29:05.820104+00:00 app[web.1]: [06/23/2022 05:29:05] ISO wasn't found. Downloading...
2022-06-23T05:29:06.002783+00:00 app[web.1]: No release specified (-Rel). Defaulting to '21H2 (Build 19044.1288 - 2021.11)'.
2022-06-23T05:29:09.406627+00:00 app[web.1]: No architecture specified (-Arch). Defaulting to 'x64'.
2022-06-23T05:29:09.407502+00:00 app[web.1]: Selected: Windows 10 21H2 (Build 19044.1288 - 2021.11), Home/Pro/Edu, English, [x64]
2022-06-23T05:29:09.480355+00:00 app[web.1]: Downloading 'Win10_21H2_English_x64.iso' (5.0 GB)...
Filadeus commented 2 years ago

Hi! Thanks for the interest in the project! I can incorporate Windows 10 ISO file inside the container while container is building, so that it will be a part of a final image of windows10-in-docker, if I understand correctly this is what you want, please correct me if I'm wrong.

bugbounted commented 2 years ago

Hello againFiladeus,

yeah thats it , but put win 10 lite version iso link to build: https://dl.bestforpc.com/Downloads/OS/Windows-10-Lite-Edition/Win_10_Pro_Build_18363.1909.476.iso it's only have ~1.1GB size instead of 5GB. below dockerfile can help you to cleancode dockerfile all in one help hint : https://github.com/rajnikantmahato/heroku20.04-root/blob/main/Dockerfile waiting for your changes. finest regards

Filadeus commented 2 years ago

Working on the new tag for the case like that. Image will have ISO built-in. Thanks for the hint, I will look into the Dockerfile from another repo you sent!

Filadeus commented 2 years ago

I looked a little bit closer into the ISO file that you mentioned in the previous comment, and I'm afraid that I can't use it. It's a repack of original Windows 10 LTSC image provided by Microsoft. Working with non official images, is sketchy to say the least. And I'm not mentioning that those images probably have been cracked, that's a violation of Windows licensing terms and probably illegal. You see I'm using only Microsoft officially provided images from their official download center (https://software.download.prss.microsoft.com), with the help from Fido project.