FileOnQ / Imaging.Heif

A C#/.NET wrapper around libheif for decoding and processing high efficiency image formats (heif, heic).
GNU Lesser General Public License v3.0
15 stars 4 forks source link

Constructor to read file from bytes #100

Open suou-ryuu opened 1 year ago

suou-ryuu commented 1 year ago

Currently the only constructor is new HeifImage(<someFilePath>) however my use-case is to process an image downloaded via HTTP, so I only have access to the image bytes. Would it be possible to add a constructor to the effect of new HeifImage(<someByteArray>)?

mitchelsellers commented 1 year ago

@suou-ryuu this is a great recommendation. I believe the best overall solution here would be to allow you to pass a Stream as that matches the typical structure.

Let us review

suou-ryuu commented 1 year ago

@mitchelsellers Sorry to pester, is there any update on this?

mitchelsellers commented 1 year ago

I will look at addressing this in the coming week

suou-ryuu commented 1 year ago

Brilliant, thank you. And sorry for being pushy

suou-ryuu commented 1 year ago

@mitchelsellers Sorry to bug you again. Is there any update on this?

(I've tried to get the library set up locally (I figured I'd implement it myself and submit a PR) but I'm having compilation issues with CMAKE)