search

FileOnQ / Imaging.Heif

A C#/.NET wrapper around libheif for decoding and processing high efficiency image formats (heif, heic).
GNU Lesser General Public License v3.0
15 stars 4 forks source link

Change CopyNativeDlls to a unique build targets name #33

Closed SkyeHoefling closed 3 years ago

SkyeHoefling commented 3 years ago

Fixes: #34

Description

Changes the build target name CopyNativeDlls -> Copy_FileOnQImagingHeif_NativeDlls to prevent naming conflict with other FileOnQ imaging libraries

Merge Checklist

github-actions[bot] commented 3 years ago

Benchmark Comparison

Benchmarking comparison between this Pull Request and the comitted values at benchmarks/results

thumbnail

 summary:
worse: 2, geomean: 1.198
total diff: 2

| Slower                                                       | diff/base | Base Median (ns) | Diff Median (ns) | Modality|
| ------------------------------------------------------------ | ---------:| ----------------:| ----------------:| --------:|
| FileOnQ.Imaging.Heif.Benchmarks.Thumbnail.Thumbnail_ToStream |      1.23 |      47627000.00 |      58643950.00 |         |
| FileOnQ.Imaging.Heif.Benchmarks.Thumbnail.Thumbnail_ToArray  |      1.17 |      47949500.00 |      55915900.00 |         |

No Faster results for the provided threshold = 10% and noise filter = 0.3ns.

No file given

primary

 No differences found between the benchmark results with threshold 10%.

Benchmark Results

thumbnail

``` ini BenchmarkDotNet=v0.13.0, OS=Windows 10.0.17763.2114 (1809/October2018Update/Redstone5) Intel Xeon CPU E5-2673 v4 2.30GHz, 1 CPU, 2 logical and 2 physical cores .NET SDK=5.0.400 [Host] : .NET 5.0.9 (5.0.921.35908), X64 RyuJIT Job-BYDAYN : .NET 5.0.9 (5.0.921.35908), X64 RyuJIT Runtime=.NET 5.0 InvocationCount=1 LaunchCount=1 UnrollFactor=1 ``` | Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | Allocated native memory | Native memory leak | |------------------- |---------:|---------:|---------:|------:|------:|------:|----------:|------------------------:|-------------------:| | Thumbnail_Write | 57.81 ms | 1.148 ms | 2.705 ms | - | - | - | 288 B | 5,125,137 B | - | | Thumbnail_ToArray | 55.97 ms | 1.090 ms | 1.212 ms | - | - | - | 66,408 B | 5,124,581 B | - | | Thumbnail_ToSpan | 55.07 ms | 1.026 ms | 1.685 ms | - | - | - | 120 B | 5,124,581 B | - | | Thumbnail_ToStream | 58.86 ms | 1.129 ms | 2.381 ms | - | - | - | 66,472 B | 5,124,325 B | - |

primary

``` ini BenchmarkDotNet=v0.13.0, OS=Windows 10.0.17763.2114 (1809/October2018Update/Redstone5) Intel Xeon Platinum 8171M CPU 2.60GHz, 1 CPU, 2 logical and 2 physical cores .NET SDK=5.0.400 [Host] : .NET 5.0.9 (5.0.921.35908), X64 RyuJIT Job-GBQJRZ : .NET 5.0.9 (5.0.921.35908), X64 RyuJIT Runtime=.NET 5.0 InvocationCount=1 LaunchCount=1 UnrollFactor=1 ``` | Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | Allocated native memory | Native memory leak | |---------------------- |--------:|---------:|---------:|------:|------:|------:|------------:|------------------------:|-------------------:| | PrimaryImage_Write | 3.019 s | 0.0181 s | 0.0161 s | - | - | - | 256 B | 222,030,028 B | - | | PrimaryImage_ToArray | 3.056 s | 0.0271 s | 0.0253 s | - | - | - | 1,943,008 B | 222,029,680 B | - | | PrimaryImage_ToSpan | 3.063 s | 0.0220 s | 0.0206 s | - | - | - | 88 B | 222,029,600 B | - | | PrimaryImage_ToStream | 3.062 s | 0.0151 s | 0.0134 s | - | - | - | 1,943,072 B | 222,029,264 B | - |

SkyeHoefling commented 3 years ago

I have pulled down the NuGet file from the build and everything works in my downstream project. I am going to merge this