Closed SkyeHoefling closed 2 years ago
Benchmarking comparison between this Pull Request and the comitted values at benchmarks/results
thumbnail
Welcome to .NET 5.0!
---------------------
SDK Version: 5.0.404
Telemetry
---------
The .NET tools collect usage data in order to help us improve your experience. It is collected by Microsoft and shared with the community. You can opt-out of telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to '1' or 'true' using your favorite shell.
Read more about .NET CLI Tools telemetry: https://aka.ms/dotnet-cli-telemetry
----------------
Installed an ASP.NET Core HTTPS development certificate.
To trust the certificate run 'dotnet dev-certs https --trust' (Windows and macOS only).
Learn about HTTPS: https://aka.ms/dotnet-https
----------------
Write your first app: https://aka.ms/dotnet-hello-world
Find out what's new: https://aka.ms/dotnet-whats-new
Explore documentation: https://aka.ms/dotnet-docs
Report issues and find source on GitHub: https://github.com/dotnet/core
Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli
--------------------------------------------------------------------------------------
No differences found between the benchmark results with threshold 10%.
primary
No differences found between the benchmark results with threshold 10%.
``` ini BenchmarkDotNet=v0.13.0, OS=Windows 10.0.17763.2366 (1809/October2018Update/Redstone5) Intel Xeon CPU E5-2673 v4 2.30GHz, 1 CPU, 2 logical and 2 physical cores .NET SDK=5.0.404 [Host] : .NET 5.0.13 (5.0.1321.56516), X64 RyuJIT Job-UORIQY : .NET 5.0.13 (5.0.1321.56516), X64 RyuJIT Runtime=.NET 5.0 InvocationCount=1 LaunchCount=1 UnrollFactor=1 ``` | Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | Allocated native memory | Native memory leak | |------------------- |---------:|---------:|---------:|------:|------:|------:|----------:|------------------------:|-------------------:| | Thumbnail_Write | 47.83 ms | 1.098 ms | 3.238 ms | - | - | - | 288 B | 5,124,409 B | - | | Thumbnail_ToArray | 53.58 ms | 1.478 ms | 4.335 ms | - | - | - | 66,408 B | 5,123,865 B | 12 B | | Thumbnail_ToSpan | 49.37 ms | 0.984 ms | 2.643 ms | - | - | - | 120 B | 5,123,885 B | 32 B | | Thumbnail_ToStream | 49.54 ms | 0.998 ms | 2.911 ms | - | - | - | 66,472 B | 5,123,853 B | - |
``` ini BenchmarkDotNet=v0.13.0, OS=Windows 10.0.17763.2366 (1809/October2018Update/Redstone5) Intel Xeon CPU E5-2673 v4 2.30GHz, 1 CPU, 2 logical and 2 physical cores .NET SDK=5.0.404 [Host] : .NET 5.0.13 (5.0.1321.56516), X64 RyuJIT Job-SZDBOU : .NET 5.0.13 (5.0.1321.56516), X64 RyuJIT Runtime=.NET 5.0 InvocationCount=1 LaunchCount=1 UnrollFactor=1 ``` | Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | Allocated native memory | Native memory leak | |---------------------- |--------:|---------:|---------:|------:|------:|------:|------------:|------------------------:|-------------------:| | PrimaryImage_Write | 2.927 s | 0.0416 s | 0.0368 s | - | - | - | 256 B | 222,028,436 B | - | | PrimaryImage_ToArray | 2.866 s | 0.0334 s | 0.0312 s | - | - | - | 1,943,008 B | 222,028,632 B | - | | PrimaryImage_ToSpan | 2.865 s | 0.0370 s | 0.0346 s | - | - | - | 88 B | 222,028,632 B | - | | PrimaryImage_ToStream | 2.893 s | 0.0240 s | 0.0224 s | - | - | - | 1,943,072 B | 222,028,536 B | - |
I have confirmed all sample projects can step into native code when compiled in debug mode. I also referenced the generated nuget package with the latest dev build on NuGet.org. All native assemblies are the same size.
We are good to merge this.
Fixes: #43
Description
Adds native code debugging for sample projects. Updates libheif, dav1d, libjpeg-turbo, and encoders to support debug vs release mode.
The samples app now let's you seamlessly step into native code through Visual Studio. You will just press F11 and step-into the native method and you will transition from C# to C++ code.
Merge Checklist