FileOnQ / Imaging.Heif

A C#/.NET wrapper around libheif for decoding and processing high efficiency image formats (heif, heic).
GNU Lesser General Public License v3.0
15 stars 4 forks source link

Updated vcredist links for x86 and x64 #86

Closed SkyeHoefling closed 2 years ago

SkyeHoefling commented 2 years ago

Fixes: #83

Description

Fixes the Visual C/C++ Redistributable links from Microsoft. It now properly includes the correct links for x86/x64.

Merge Checklist

github-actions[bot] commented 2 years ago

Benchmark Comparison - .NET Framework 4.8

Benchmarking comparison between this Pull Request and the comitted values at benchmarks/results

thumbnail

 summary:
better: 4, geomean: 1.226
total diff: 4

No Slower results for the provided threshold = 10% and noise filter = 0.3ns.

| Faster                                                       | base/diff | Base Median (ns) | Diff Median (ns) | Modality|
| ------------------------------------------------------------ | ---------:| ----------------:| ----------------:| --------:|
| FileOnQ.Imaging.Heif.Benchmarks.Thumbnail.Thumbnail_ToSpan   |      1.25 |      58913500.00 |      47298300.00 |         |
| FileOnQ.Imaging.Heif.Benchmarks.Thumbnail.Thumbnail_ToStream |      1.23 |      59449850.00 |      48285300.00 |         |
| FileOnQ.Imaging.Heif.Benchmarks.Thumbnail.Thumbnail_Write    |      1.22 |      59505900.00 |      48931500.00 |         |
| FileOnQ.Imaging.Heif.Benchmarks.Thumbnail.Thumbnail_ToArray  |      1.21 |      58636250.00 |      48440900.00 |         |

No file given

primary

 summary:
better: 4, geomean: 1.292
total diff: 4

No Slower results for the provided threshold = 10% and noise filter = 0.3ns.

| Faster                                                             | base/diff | Base Median (ns) | Diff Median (ns) | Modality|
| ------------------------------------------------------------------ | ---------:| ----------------:| ----------------:| --------:|
| FileOnQ.Imaging.Heif.Benchmarks.PrimaryImage.PrimaryImage_Write    |      1.41 |    2982269900.00 |    2117496150.00 |         |
| FileOnQ.Imaging.Heif.Benchmarks.PrimaryImage.PrimaryImage_ToSpan   |      1.31 |    2829898300.00 |    2166837700.00 |         |
| FileOnQ.Imaging.Heif.Benchmarks.PrimaryImage.PrimaryImage_ToStream |      1.27 |    2766976750.00 |    2172836950.00 |         |
| FileOnQ.Imaging.Heif.Benchmarks.PrimaryImage.PrimaryImage_ToArray  |      1.19 |    2743673900.00 |    2305760600.00 |         |

No file given

Benchmark Results - .NET Framework 4.8

thumbnail

``` ini BenchmarkDotNet=v0.13.1, OS=Windows 10.0.17763.2458 (1809/October2018Update/Redstone5), VM=Hyper-V Intel Xeon Platinum 8272CL CPU 2.60GHz, 1 CPU, 2 logical and 2 physical cores [Host] : .NET Framework 4.8 (4.8.4420.0), X64 RyuJIT Job-GHSIOX : .NET Framework 4.8 (4.8.4420.0), X64 RyuJIT Runtime=.NET Framework 4.8 InvocationCount=1 LaunchCount=1 UnrollFactor=1 ``` | Method | Mean | Error | StdDev | Allocated native memory | Native memory leak | Allocated | |------------------- |---------:|---------:|---------:|------------------------:|-------------------:|----------:| | Thumbnail_Write | 48.99 ms | 0.378 ms | 0.353 ms | 5,123,891 B | - | 74,504 B | | Thumbnail_ToArray | 48.33 ms | 0.280 ms | 0.262 ms | 5,123,563 B | - | 74,504 B | | Thumbnail_ToSpan | 47.33 ms | 0.186 ms | 0.156 ms | 5,123,307 B | - | - | | Thumbnail_ToStream | 48.24 ms | 0.409 ms | 0.383 ms | 5,123,307 B | - | 140,816 B |

primary

``` ini BenchmarkDotNet=v0.13.1, OS=Windows 10.0.17763.2458 (1809/October2018Update/Redstone5), VM=Hyper-V Intel Xeon Platinum 8272CL CPU 2.60GHz, 1 CPU, 2 logical and 2 physical cores [Host] : .NET Framework 4.8 (4.8.4420.0), X64 RyuJIT Job-GHSIOX : .NET Framework 4.8 (4.8.4420.0), X64 RyuJIT Runtime=.NET Framework 4.8 InvocationCount=1 LaunchCount=1 UnrollFactor=1 ``` | Method | Mean | Error | StdDev | Median | Allocated native memory | Native memory leak | Allocated | |---------------------- |--------:|---------:|---------:|--------:|------------------------:|-------------------:|------------:| | PrimaryImage_Write | 2.120 s | 0.0210 s | 0.0164 s | 2.117 s | 222,029,342 B | - | 1,951,112 B | | PrimaryImage_ToArray | 2.299 s | 0.0439 s | 0.0411 s | 2.306 s | 222,028,886 B | - | 1,951,112 B | | PrimaryImage_ToSpan | 2.207 s | 0.0432 s | 0.0659 s | 2.167 s | 222,029,094 B | - | - | | PrimaryImage_ToStream | 2.172 s | 0.0075 s | 0.0059 s | 2.173 s | 222,028,934 B | - | 3,894,032 B |

Benchmark Comparison - .NET 5

Benchmarking comparison between this Pull Request and the comitted values at benchmarks/results

thumbnail

 No differences found between the benchmark results with threshold 10%.

primary

 summary:
better: 4, geomean: 1.208
total diff: 4

No Slower results for the provided threshold = 10% and noise filter = 0.3ns.

| Faster                                                             | base/diff | Base Median (ns) | Diff Median (ns) | Modality|
| ------------------------------------------------------------------ | ---------:| ----------------:| ----------------:| --------:|
| FileOnQ.Imaging.Heif.Benchmarks.PrimaryImage.PrimaryImage_ToSpan   |      1.22 |    2976810300.00 |    2443546750.00 |         |
| FileOnQ.Imaging.Heif.Benchmarks.PrimaryImage.PrimaryImage_ToStream |      1.22 |    2982379850.00 |    2451762650.00 |         |
| FileOnQ.Imaging.Heif.Benchmarks.PrimaryImage.PrimaryImage_Write    |      1.21 |    2905592400.00 |    2402763950.00 |         |
| FileOnQ.Imaging.Heif.Benchmarks.PrimaryImage.PrimaryImage_ToArray  |      1.19 |    2920373000.00 |    2460902600.00 |         |

No file given

Benchmark Results - .NET 5

thumbnail

``` ini BenchmarkDotNet=v0.13.1, OS=Windows 10.0.17763.2458 (1809/October2018Update/Redstone5) Intel Xeon Platinum 8171M CPU 2.60GHz, 1 CPU, 2 logical and 2 physical cores .NET SDK=6.0.101 [Host] : .NET 5.0.8 (5.0.821.31504), X64 RyuJIT Job-ZTPWRK : .NET 5.0.8 (5.0.821.31504), X64 RyuJIT Runtime=.NET 5.0 InvocationCount=1 LaunchCount=1 UnrollFactor=1 ``` | Method | Mean | Error | StdDev | Allocated native memory | Native memory leak | Allocated | |------------------- |---------:|---------:|---------:|------------------------:|-------------------:|----------:| | Thumbnail_Write | 56.31 ms | 1.100 ms | 1.681 ms | 5,124,425 B | - | 288 B | | Thumbnail_ToArray | 55.67 ms | 0.831 ms | 0.737 ms | 5,123,853 B | - | 66,408 B | | Thumbnail_ToSpan | 58.56 ms | 1.160 ms | 3.096 ms | 5,123,853 B | - | 120 B | | Thumbnail_ToStream | 58.33 ms | 1.043 ms | 0.976 ms | 5,123,853 B | - | 66,472 B |

primary

``` ini BenchmarkDotNet=v0.13.1, OS=Windows 10.0.17763.2458 (1809/October2018Update/Redstone5) Intel Xeon Platinum 8272CL CPU 2.60GHz, 1 CPU, 2 logical and 2 physical cores .NET SDK=6.0.101 [Host] : .NET 5.0.8 (5.0.821.31504), X64 RyuJIT Job-OSITAI : .NET 5.0.8 (5.0.821.31504), X64 RyuJIT Runtime=.NET 5.0 InvocationCount=1 LaunchCount=1 UnrollFactor=1 ``` | Method | Mean | Error | StdDev | Allocated native memory | Native memory leak | Allocated | |---------------------- |--------:|---------:|---------:|------------------------:|-------------------:|------------:| | PrimaryImage_Write | 2.398 s | 0.0370 s | 0.0328 s | 222,029,332 B | - | 256 B | | PrimaryImage_ToArray | 2.454 s | 0.0189 s | 0.0177 s | 222,028,872 B | - | 1,943,008 B | | PrimaryImage_ToSpan | 2.444 s | 0.0059 s | 0.0055 s | 222,028,888 B | - | 88 B | | PrimaryImage_ToStream | 2.451 s | 0.0099 s | 0.0088 s | 222,028,744 B | - | 1,943,072 B |

Benchmark Comparison - .NET 6

Benchmarking comparison between this Pull Request and the comitted values at benchmarks/results

thumbnail

 No differences found between the benchmark results with threshold 10%.

primary

 summary:
better: 4, geomean: 1.206
total diff: 4

No Slower results for the provided threshold = 10% and noise filter = 0.3ns.

| Faster                                                             | base/diff | Base Median (ns) | Diff Median (ns) | Modality|
| ------------------------------------------------------------------ | ---------:| ----------------:| ----------------:| --------:|
| FileOnQ.Imaging.Heif.Benchmarks.PrimaryImage.PrimaryImage_ToStream |      1.22 |    2979033400.00 |    2449999000.00 |         |
| FileOnQ.Imaging.Heif.Benchmarks.PrimaryImage.PrimaryImage_ToSpan   |      1.21 |    2975119200.00 |    2452057800.00 |         |
| FileOnQ.Imaging.Heif.Benchmarks.PrimaryImage.PrimaryImage_ToArray  |      1.20 |    2893204600.00 |    2410662600.00 |         |
| FileOnQ.Imaging.Heif.Benchmarks.PrimaryImage.PrimaryImage_Write    |      1.19 |    2872608900.00 |    2404409900.00 |         |

No file given

Benchmark Results - .NET 6

thumbnail

``` ini BenchmarkDotNet=v0.13.1, OS=Windows 10.0.17763.2458 (1809/October2018Update/Redstone5) Intel Xeon Platinum 8272CL CPU 2.60GHz, 1 CPU, 2 logical and 2 physical cores .NET SDK=6.0.101 [Host] : .NET 6.0.1 (6.0.121.56705), X64 RyuJIT Job-ZQZADD : .NET 6.0.1 (6.0.121.56705), X64 RyuJIT Runtime=.NET 6.0 InvocationCount=1 LaunchCount=1 UnrollFactor=1 ``` | Method | Mean | Error | StdDev | Allocated native memory | Native memory leak | Allocated | |------------------- |---------:|---------:|---------:|------------------------:|-------------------:|----------:| | Thumbnail_Write | 48.59 ms | 0.908 ms | 0.849 ms | 5,124,409 B | - | 832 B | | Thumbnail_ToArray | 47.77 ms | 0.359 ms | 0.336 ms | 5,123,853 B | - | 66,888 B | | Thumbnail_ToSpan | 47.66 ms | 0.274 ms | 0.243 ms | 5,123,853 B | - | 600 B | | Thumbnail_ToStream | 47.50 ms | 0.172 ms | 0.153 ms | 5,123,853 B | - | 66,952 B |

primary

``` ini BenchmarkDotNet=v0.13.1, OS=Windows 10.0.17763.2458 (1809/October2018Update/Redstone5) Intel Xeon Platinum 8272CL CPU 2.60GHz, 1 CPU, 2 logical and 2 physical cores .NET SDK=6.0.101 [Host] : .NET 6.0.1 (6.0.121.56705), X64 RyuJIT Job-BRNOJY : .NET 6.0.1 (6.0.121.56705), X64 RyuJIT Runtime=.NET 6.0 InvocationCount=1 LaunchCount=1 UnrollFactor=1 ``` | Method | Mean | Error | StdDev | Allocated native memory | Native memory leak | Allocated | |---------------------- |--------:|---------:|---------:|------------------------:|-------------------:|------------:| | PrimaryImage_Write | 2.406 s | 0.0103 s | 0.0096 s | 222,029,316 B | - | 848 B | | PrimaryImage_ToArray | 2.410 s | 0.0051 s | 0.0048 s | 222,028,664 B | - | 1,943,536 B | | PrimaryImage_ToSpan | 2.453 s | 0.0050 s | 0.0047 s | 222,028,680 B | - | 616 B | | PrimaryImage_ToStream | 2.451 s | 0.0054 s | 0.0051 s | 222,028,840 B | - | 1,943,600 B |

SkyeHoefling commented 2 years ago

This is just a documentation PR, I am self approving and merging