FileShuttle / fileshuttle

The FileShuttle Mac App - http://fileshuttle.io
MIT License
235 stars 17 forks source link

Allow for file permission modification after upload with SFTP #2

Closed felinira closed 10 years ago

felinira commented 10 years ago

This allows for SFTP uploads to change the file permission after uploading the file. This is particulary useful if you have a web server that needs specific permissions to host a file.

felinira commented 10 years ago

It only changes those two views. As you can see it adds the option at the bottom. As it only works with SSH it greys out the option for FTP. I have it running for four months in production on two systems (both 10.9) and it is working just fine (without any problems at all). In retrospect it would probably be better to do some more input validation and/or display the permissions in a checkbox-like view.

screen shot 2014-04-01 at 23 17 27 screen shot 2014-04-01 at 23 17 15

phillipthelen commented 10 years ago

Is there any update in this PR? I could really use this feature.

AydinHassan commented 10 years ago

:+1: This feature would be nice to have

anthonysomerset commented 10 years ago

why can't this be allowed for FTP? FTP supports permission changing as well, will merge this now but its worth opening a issue/PR to allow permissions change on FTP also

jpmens commented 10 years ago

According to the project README, this is in 2.x-dev, but the additional options for SFTP don't show up in Fileshuttle's preferences pane I see. I've tried setting

    "change_permissions" = 1;
    "permission_string" = 0644;

with defaults write on OS X 10.8.5 but the permissions of the file uploaded via SFTP aren't changed.

Did this pull-request actually make it into 2.x-dev.zip, and if so, can you tell me what I should do to enable the chmod feature?

anthonysomerset commented 10 years ago

I haven't recently provided an updated build in dev, let me get round to that!

JP Mens mailto:notifications@github.com 20 August 2014 at 10:41

According to the project README, this is in 2.x-dev, but the additional options for SFTP don't show up in Fileshuttle's preferences pane I see. I've tried setting

"change_permissions" = 1; "permission_string" = 0644;

with |defaults write| on OS X 10.8.5 but the permissions of the file uploaded via SFTP aren't changed.

Did this pull-request actually make it into 2.x-dev.zip, and if so, can you tell me what I should do to enable the chmod feature?

— Reply to this email directly or view it on GitHub https://github.com/FileShuttle/fileshuttle/pull/2#issuecomment-52748809.

jpmens commented 10 years ago

I'd appreciate that!