Closed barbaraperic closed 2 days ago
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
filecoin-foundation-site | โ Ready (Inspect) | Visit Preview | ๐ฌ Add feedback | Nov 11, 2024 10:15am |
I've suggested some rework @barbaraperic, we can discuss and/or implement these live if you want :)
Also, regarding your question in the PR description, could we add the
md:w-40
in the layout component as below?FilterContainer.MobileFiltersAndResults = function MobileFiltersAndResults({ search, category, sort, results, }: FilterProps) { return ( <div className="flex flex-col gap-4 lg:hidden"> <div className="flex flex-col gap-3 sm:flex-row"> {search} <div className="flex flex-1 gap-3 sm:flex-row"> <div className="w-full md:w-40">{category}</div> <div className="max-fit md:w-40">{sort}</div> </div> </div> {results} </div> ) }
Ah great yes, thank you. I tried that, but some reason I thought it didn't work.
๐ Description
This PR refactors the
ListboxButton
component and replaces theHeadless UI ListboxButton
with our custom implementation.ListboxButton
icon, how can we avoidprefixIcon ?? CaretDown
ifisCompact
is true๐ ๏ธ Key Changes
ListboxButton
componentuseViewport
hook - wanted to avoid nesting divs with classeshidden md:block
asLisboxButton
needs to be a direct descendants ofListbox
, otherwise it breaks. Example on theblog
page, where we conditionally renderLisboxButton
withArrowUpDown
icon if on mobile screen.๐งช How to Test
ListboxButton
is used in sorting/filtering parts inblog
,events
,ecosystem-explorer
and in mobile view insecurity/maturity-model