FilipePS / Traduzir-paginas-web

Translate your page in real time using Google or Yandex
https://addons.mozilla.org/pt-BR/firefox/addon/traduzir-paginas-web/
Mozilla Public License 2.0
4.58k stars 554 forks source link

[Bug] In 10.0.0.4 the color of the icon in the address bar is always "active"/"translate page" #799

Open vitalii2011 opened 8 months ago

vitalii2011 commented 8 months ago

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. Click on '...'

Expected Result

Image 001 Image 002

Actual Result

Screenshots or Videos

No response

Additional Context

No response

Operating System

Windows

Operating System Version

No response

Web Browser

Firefox

Browser Version

No response

Extension Version

10.0.0.4

What are you doing?

FilipePS commented 8 months ago

What theme are you using?

vitalii2011 commented 8 months ago

https://addons.mozilla.org/ru/firefox/addon/beautiful-opera-dark/

JackASil commented 8 months ago

same, using Matte Black (White) from [Elijah Lopez] https://addons.mozilla.org/firefox/addon/matte-black-theme/

FilipePS commented 8 months ago

I made some corrections to the colors, but the big problem is that these themes define the icons_attention property with a color very similar to the color of the toolbar_field_text property, so it is difficult to differentiate. Maybe in the future I will change the extension icon so that it fills with the icons_attention color (in the same way as with the favorite star).

vitalii2011 commented 8 months ago

But before 10.0.0.4 this problem did not exist. Or are "some corrections to the colors" very important?

FilipePS commented 8 months ago

But before 10.0.0.4 this problem did not exist. Or are "some corrections to the colors" very important?

For the Beautiful Opera Dark theme you can see the difference in colors when translated, but with the Matte Black (White) theme the difference is very subtle.

The reason the color difference was more noticeable before (in those themes) is because the extension was using the wrong transparency.

The color corrections made from version 10.0 are important, there were situations where the icon was invisible, for example.

Although version 10.0.1 has not yet been reviewed by Mozilla, you can install the self-hosted version in advance, available here: https://github.com/FilipePS/Traduzir-paginas-web/releases/tag/v10.0.1.0

vitalii2011 commented 8 months ago