FilippoAiraldi / mpcrl-for-ramp-metering

Highway Traffic Control with MPC-based RL
GNU General Public License v3.0
12 stars 2 forks source link

Size and Range of Actions #3

Open prajwalvinod opened 2 months ago

prajwalvinod commented 2 months ago

Hey @FilippoAiraldi,

When you say redefine the dynamics, where would I do that exactly ? Would it be in the get_network function or directly in the traffic environment ?

I ask since in the traffic environment I see the shape defined as na = self.na followed by the line self.action_space = Box( 0.0, 1.0 if control_O2_rate else np.inf, (na,), np.float64 ) which was a bit confusing to me as it seems to imply that the environment can define the shape of the action space by itself so I assumed by adding the LinkWithVsl would automatically do this.

Also what is the range of actions that can be taken for VSL ? As in is it [0,1] and then multiplied by a certain factor or is it directly a range of speeds like [40,100] ?

If you could clarify this it would be helpful.

Regards

Prajwal

P.S. Its my first time using this package so I am a bit unfamiliar with it. Sorry for the inconvenience.