FilippoCarloni / the_42nd_sagrada

The 42nd Sagrada: a software engineering university project.
MIT License
0 stars 0 forks source link

Program does not compile since 25th of April #2

Closed n1zzo closed 6 years ago

n1zzo commented 6 years ago

It is not acceptable that your software does not have a single successful build in 15 days. You have been writing code since then without even making it even compile, or you are not committing frequently enough to master. We remember that feature branches must be committed to master ~ every week. Please fix asap.

Niccolò

archettialberto commented 6 years ago

We fixed yesterday with your help the version of JUnit 5 that made the project compile on our laptops but not on Jenkins. The project does not compile (as you said yesterday) because we have some JavaFX code already written in the branch master, that is not already compilable by Jenkins. We asked if it was an issue, but you said that there wasn't any problem because the JavaFX compilation was actually a Jenkins issue. If there's something that we still need to do please tell us, because the Java code compiles on our laptops and we have no way to verify that compiles on Jenkins too.

ingconti commented 6 years ago

As per 8th night jenkins can process correctly FX. But you have other errors:

[INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /var/jenkins_home/workspace/LM42/src/main/java/it/polimi/ingsw/view/viewDemo/databaseView/Die.java:[3,56] package com.sun.xml.internal.bind.v2.runtime.reflect.opt does not exist

so pls fix ASAP

valerio-castelli commented 6 years ago

UP: your code is still not compiling due to this dependency issue. Please fix ASAP.

FilippoCarloni commented 6 years ago

We have fixed the previous package error and now( as prevously) in our laptops compiles and executed correctly. Please, could you show us if there are other Jenkins errors? Thanks for the help, Filippo

valerio-castelli commented 6 years ago

I am closing the issue as the project is now compiling fine.