search

FiloSottile / age

A simple, modern and secure encryption tool (and Go library) with small explicit keys, no config options, and UNIX-style composability.
https://age-encryption.org
BSD 3-Clause "New" or "Revised" License
17.26k stars 506 forks source link

increase decryption recipient limit from 20 to 1000 #140

Closed ryantm closed 3 years ago

ryantm commented 4 years ago

closes #139

I tested decrypting my file with 69 recipients and it worked.

ryantm commented 4 years ago

CI build failure appears to be unrelated.

# filippo.io/age/internal/bech32_test
173internal/bech32/bech32_test.go:46:12: conversion from untyped int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
johanfleury commented 4 years ago

Why even keep a limit here? There’s not comments in the code and I can’t find a replay of the Twitch stream mentioned in the commit message.

I think, if we keep this limit (either increasing it or keeping it as is), we should document it somehow.

@FiloSottile could you explain the reason behind this check?

ryantm commented 4 years ago

The limit does not exist in the specification or the rage implementation.

str4d commented 3 years ago

See #139 for continued discussion.