FiloSottile / gvt

gvt was a minimal go vendoring tool, based on gb-vendor. Today, you want to use modules instead.
MIT License
729 stars 67 forks source link

Private repository support request #54

Open ghost opened 8 years ago

ghost commented 8 years ago

This is a feature request, not a bug report.

It would be nice if GVT added support for private repositories. There's some discussion for git repositories here, and a script for bitbucket here. Russ Cox mentions here that bad private repo support it's a design flaw in Go, but the discussion is an old one.

The issue is in Go; it would be super useful, and extremely relevant to gvt's use case, if a solution were included in gvt.

ghost commented 8 years ago

A hack-around that works is to manually edit the manifest and add in the dependencies array, e.g.:

                {
                        "importpath": "bitbucket.org/privateorg/privateproj",
                        "repository": "ssh://hg@bitbucket.org/privateorg/privateproj",
                        "revision": "ab5f07cc4b37",
                        "branch": "default"
                },

Since all contributors access bitbucket as hg@bitbucket.org, this works across development teams. This has to be added only once and committed, then GVT works fine with other debs.