search

FiloSottile / typage

A TypeScript implementation of the age file encryption format, based on libsodium.
BSD 3-Clause "New" or "Revised" License
105 stars 14 forks source link

node and bun compatibility #13

Closed FiloSottile closed 1 year ago

FiloSottile commented 1 year ago

@lgarron, this is basically #11 with slightly different choices here and there. Please don't take this negatively, I almost always redo PRs to make sure I understand every moving part, and your PR was really useful to follow and appreciated.

If you have the time, I'd also appreciate a review of this!

FiloSottile commented 1 year ago

TypeError: crypto_hash_sha256 is not a function

How... how is it passing in the "Test / test (20.x) (pull_request)" job and not in the "Test / test (20.x) (push)". Wat.

FiloSottile commented 1 year ago

Oh, I see, I need to await before assigning. Hell, this ready thing is awful.

FiloSottile commented 1 year ago

Merged by mistake 🤦‍♂️

FiloSottile commented 1 year ago

Reopened as #14