search

FiloSottile / yubikey-agent

yubikey-agent is a seamless ssh-agent for YubiKeys.
https://filippo.io/yubikey-agent
BSD 3-Clause "New" or "Revised" License
2.6k stars 124 forks source link

Switch to github.com/twpayne/go-pinentry-minimal #113

Closed twpayne closed 2 years ago

twpayne commented 2 years ago

As suggested by the author of github.com/gopasspw/pinentry.

FiloSottile commented 2 years ago

The extra dependencies are a blocker, better pinentry support is not worth pulling in dependencies from three different organizations/authors. Are they necessary non-test dependencies of go-pinentry?

twpayne commented 2 years ago

Are they necessary non-test dependencies of go-pinentry?

Nope, they're there for rich functionality, not necessary functionality. The core pinentry functionality only depends on the Go standard library.

Would you accept a version of go-pinentry that only has standard library dependencies?

FiloSottile commented 2 years ago

Yeah, it looks comparable in amount of complexity, if the gopasspw folks recommended it I'd be happy to switch.

twpayne commented 2 years ago

OK, PR updated to use the minimal fork: https://github.com/twpayne/go-pinentry-minimal.

PTA(nother)L.

FiloSottile commented 2 years ago

LGTM, thank you. Please drop the .gitignore commit, I generally prefer not to check in workflow-specific gitignores.

twpayne commented 2 years ago

Please drop the .gitignore commit

Done.