search

FinTecSystems / xs2a-android

[Client] Native Android SDK for Tink Germany XS2A API.
https://tink.com/de/fts
Other
6 stars 4 forks source link

Fix enable scroll issue #17

Closed hossamCheck24 closed 11 months ago

hossamCheck24 commented 11 months ago

Hey Mike, could you kindly take a look at this PR? I believe it might address the issue of not maintaining state and ensure that we avoid using the fragment constructor.

sonatype-lift[bot] commented 11 months ago

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

maik-mursall commented 11 months ago

Hi @hossamCheck24, thank you for you PR :)

Please run ./gradlew assemble within the project root. You'll find the artifacts under xs2awizard/build/outputs/aar. Please use this artifact to test within your (test)-app if it fixes your issue.

Because what your PR does is moving the secondary constructor to the factory method. The primary constructor, the important one for the Android lifecycle, is empty and thus the state recreation, etc., is still given.

I don't think that moving to a factory method will resolve your issue with nested scrolling 🤔

hossamCheck24 commented 11 months ago

l am aready open other pr could you please check

maik-mursall commented 11 months ago

@hossamCheck24 I will close this PR since, there is no change necessary.