Bugfix/llegal argument exception height

FinTecSystems / xs2a-android

[Client] Native Android SDK for Tink Germany XS2A API.

https://tink.com/de/fts

Other

6 stars 4 forks source link

Bugfix/llegal argument exception height #19

Closed hossamCheck24 closed 11 months ago

hossamCheck24 commented 11 months ago

when we try to test the application again i found this crash happen so i open other PR with fix could you check it please

hossamCheck24 commented 11 months ago

@maik-mursall could you check this please ?

maik-mursall commented 11 months ago

Hi @hossamCheck24, thanks again for the PR.

Did you try to build this change to confirm it fixes your Issue? Other than that I would like to have fillMaxSize even if scrolling is disabled. But I agree that .height(IntrinsicSize.Min) may only be necessary if scrolling is enabled.

enghossamelsawy commented 11 months ago

i already insert SDK as Module and try this fix and work fine

the problem
when enabling scroll false and set .height(IntrinsicSize.Min)

this what case the crash

maik-mursall commented 11 months ago

@hossamCheck24 I've actually managed to reproduce the same crash :) It occurs when you disable scroll and when you start a second session.

Means it will work perfectly for the first flow but all subsequent flows will crash.

I can confirm, that your fix works :)

maik-mursall commented 11 months ago

@hossamCheck24 I've released this under v5.1.4.

It will be available on MavenCentral within the next few hours 🎉