search

FinTecSystems / xs2a-android

[Client] Native Android SDK for Tink Germany XS2A API.
https://tink.com/de/fts
Other
6 stars 4 forks source link

fix infinite loading due to unregister network call #4

Closed hossamCheck24 closed 1 year ago

hossamCheck24 commented 1 year ago

the infinite loading is happening due to the SDK. They register a listener in the creation of a singleton, but then they remove the listeners on the onStop of a fragment

then the singleton for the network does not have any callbacks to run anymore so it stuck in infinite loading when try to remove NetworkingInstance.getInstance(context).finalize() it work fine the best solution is to register on start based on life cycle

maik-mursall commented 1 year ago

Hi @hossamCheck24, thank you for your PR :).

I finally managed to reproduce the Issue so thank you for the fix!

I will update you when the release is triggered.

maik-mursall commented 1 year ago

I just triggered the v3.12.1 release.

It will be available within the next few hours on MavenCentral.