- Add option to add you own loading to fix Problem of Loader doesn't …

FinTecSystems / xs2a-android

[Client] Native Android SDK for Tink Germany XS2A API.

https://tink.com/de/fts

Other

6 stars 4 forks source link

- Add option to add you own loading to fix Problem of Loader doesn't … #7

Closed hossamCheck24 closed 1 year ago

hossamCheck24 commented 1 year ago

Add option to add you own loading to fix Problem of Loader doesn't fill the screen

maik-mursall commented 1 year ago

Hi @hossamCheck24, thank you again for the PR :)

Adding a onLoading callback seems fair enough, but I think it may also be good to have a way to disable the default loading indicator. Maybe adding another field to the XS2AWizardConfig like enableDefaultLoadingIndicator and setting its default value to true? At least I think that should be present, so you will be able to entirely use your own loading indicator implementation.

Please let me know what you think about this :)

hossamCheck24 commented 1 year ago

Hi @maik-mursall Thanks for code review :D i will work on it and will let you know when it finished thanks a lot