FinalsClub / karmaworld

KarmaNotes.org v3.0
GNU Affero General Public License v3.0
7 stars 6 forks source link

Look into Fabric here / [local]host #168

Closed ghost closed 10 years ago

ghost commented 10 years ago

Verify or fix local fabric issues

btbonval commented 10 years ago

As a possible replacement of "fab here blah", try "fab -H localhost blah". On Nov 12, 2013 7:02 PM, "Robert Call" notifications@github.com wrote:

Verify or fix local fabric issues

— Reply to this email directly or view it on GitHubhttps://github.com/FinalsClub/karmaworld/issues/168 .

btbonval commented 10 years ago

As I have been modifying the fabfile for VM deployment, I should note that replacing the here() method will require rewriting a lot of the code. The functions that make use of here() (or assume it is in use) break common assumptions/practices for using fabric. This is requiring quite a lot of overhaul while writing up deployment code.

btbonval commented 10 years ago

As far as I can tell, the here and prod tasks are fabric antipatterns. Fabric is meant to run code a specific way for systems specified using -H command flag. These two functions change various configuration parameters (which is seemingly dependent upon the host being deployed to, e.g. local or staging/production).

Instead, there should be external configuration which is read in without the use of functions in fabric such as here. The external configuration should store differences in systems, etc. Fabric scripts can be deployed to localhost using -H 127.0.0.1.

I have removed here from my working branch, but I have not gone very far in cleaning up the fabfile.