search

FinalsClub / karmaworld

KarmaNotes.org v3.0
GNU Affero General Public License v3.0
7 stars 6 forks source link

admin panel should inherit from moderator panel #268

Open btbonval opened 10 years ago

btbonval commented 10 years ago

Right now the moderator panel is pretty slick, while the admin panel is weak sauce.

It'd be great if the admin panel inherited all the moderator panel functionality so it was at least as slick.

AndrewMagliozzi commented 10 years ago

Yes!

On Jan 10, 2014, at 5:15 PM, Bryan Bonvallet notifications@github.com wrote:

Right now the moderator panel is pretty slick, while the admin panel is weak sauce.

It'd be great if the admin panel inherited all the moderator panel functionality so it was at least as slick.

— Reply to this email directly or view it on GitHub.

btbonval commented 10 years ago

The moderator interface will still be needed as it represents a reduced privilege set.

The right way to do this is to pull the admin definitions out of moderator/admin.py and place them into the respective <collection>/admin.py files with expanded privileges.

I initially thought inheriting from moderator would be an easy way to keep these definitions centralized, but moderator/admin.py already imports from <collection>/admin.py files. Circular dependencies are circular. Best to put it in the right spot from the start.

btbonval commented 9 years ago

It seems like the admin interface is blocking capabilities that should exist, making this a bug rather than an enhancement.