search

FinalsClub / karmaworld

KarmaNotes.org v3.0
GNU Affero General Public License v3.0
7 stars 6 forks source link

Fix HTML from GDrive processing #271

Closed AndrewMagliozzi closed 10 years ago

AndrewMagliozzi commented 10 years ago

The width of notes we get back from GDrive often causes legibility problems for notes. See this for example:

http://karmanotes.org/harvard/government-1780-118/3-contemp-international-economic-system-923-925-930-1-12-547252

This might also be an issue with the width of 'div#note-text" we use to wrap those notes on our end... or the iframe within it.

btbonval commented 10 years ago

Not that it helps, but sanitize_html presently converts anchor tags to open in a new window and does nothing else.

If the problem is something to do with the markup inside the HTML, we might want to add the fix to sanitize_html.

btbonval commented 10 years ago

btw sanitize_html is gone now.

btbonval commented 10 years ago

Not all notes. Certain notes. Like the one above.

This is particularly obvious on mobile devices.

JHilker commented 10 years ago

Do we have the original source for that note / others where the issue occurs? I downloaded the one mentioned above off file picker, put it into mine, and re-uploaded it locally and it appeared to display fine.

btbonval commented 10 years ago

You checked it on mobile devices? I guess that is where it was really apparent. @AndrewMagliozzi will really have to be the one to comment on this, though.

AndrewMagliozzi commented 10 years ago

I think it's better I take a minute to show you the problem, Jacob. I'll do so tomorrow when we meet.

On Feb 3, 2014, at 1:31 AM, Bryan Bonvallet notifications@github.com wrote:

You checked it on mobile devices? I guess that is where it was really apparent. @AndrewMagliozzi will really have to be the one to comment on this, though.

— Reply to this email directly or view it on GitHub.

AndrewMagliozzi commented 10 years ago

The only issue with this is currently tabs in word docs that are uploaded and converted to HTML. On the large screen there is no problem, but there is an issue of readability on the small screen, notably iPhone / Android.

AndrewMagliozzi commented 10 years ago

see notes like this on mobile: http://karmanotes.org/harvard/reason-and-faith-in-the-west/god-and-nature-chapters-1-

AndrewMagliozzi commented 10 years ago

I think we can close this ticket now that we've merged the markdown branch.

JHilker commented 10 years ago

Closed via https://github.com/FinalsClub/karmaworld/issues/332, using markdown instead of iframe's