FinalsClub / karmaworld

KarmaNotes.org v3.0
GNU Affero General Public License v3.0
7 stars 6 forks source link

django-kombu dependency for dev #276

Closed btbonval closed 10 years ago

btbonval commented 10 years ago

I wonder if django-kombu is necessary. According to pypi, it is deprecated. https://pypi.python.org/pypi/django-kombu

Additionally, it looks like django-kombu is supposed to attach django to kombu, but kombu is not a dependency anywhere. maybe django-kombu causes kombu to be installed?

At any rate, the VM and @charlesconnell are both using RabbitMQ in dev, which means this particular requirement is not only different from prod, it's entirely unused by any devs.

btbonval commented 10 years ago

weird. I just ran an install that I noticed included kombu:

Successfully installed Django django-celery django-compressor Fabric South supervisor oauth2client urllib3 google-api-python-client django-grappelli lxml django-filepicker filemagic fabric-virtualenv requests beautifulsoup4 pyopenssl python-twitter gdshortener html2text django-allauth boto cssmin pylibmc django-storages gunicorn jsmin psycopg2 amqplib django-debug-toolbar ipython ipdb django-extensions django-nose coverage selenium mock django-taggit anyjson indextank pytz celery django-appconf paramiko meld3 httplib2 python-gflags simplejson oauth2 requests-oauthlib python-openid nose billiard python-dateutil kombu six pycrypto ecdsa oauthlib amqp

kombu is not explicitly referred to common.txt, prod.txt, or vmdev.txt, yet there it is. django-kombu was not installed (nor was it requested to be).

what requires kombu in that list?

sethwoodworth commented 10 years ago

It is a requirement of celery I believe. The packages in the requirement file have their own requirements. Pip should be able to show you a dependency tree. On Jan 14, 2014 11:16 PM, "Bryan Bonvallet" notifications@github.com wrote:

weird. I just ran an install that I noticed included kombu:

Successfully installed Django django-celery django-compressor Fabric South supervisor oauth2client urllib3 google-api-python-client django-grappelli lxml django-filepicker filemagic fabric-virtualenv requests beautifulsoup4 pyopenssl python-twitter gdshortener html2text django-allauth boto cssmin pylibmc django-storages gunicorn jsmin psycopg2 amqplib django-debug-toolbar ipython ipdb django-extensions django-nose coverage selenium mock django-taggit anyjson indextank pytz celery django-appconf paramiko meld3 httplib2 python-gflags simplejson oauth2 requests-oauthlib python-openid nose billiard python-dateutil kombu six pycrypto ecdsa oauthlib amqp

kombu is not explicitly referred to common.txt, prod.txt, or vmdev.txt, yet there it is. django-kombu was not installed (nor was it requested to be).

what requires kombu in that list?

— Reply to this email directly or view it on GitHubhttps://github.com/FinalsClub/karmaworld/issues/276#issuecomment-32333554 .

btbonval commented 10 years ago

Clearly kombu is installed as a dependency or else it wouldn't be there at all ;)

I thought kombu was a replacement for celery, since they do the same thing: implement AMQP. dev seemed to use kombu while prod used celery, but bumping into this has made me wonder.

I didn't know pip showed req tree. I'll look into that, thanks for the tip.

On Tue, Jan 14, 2014 at 8:26 PM, Seth Woodworth notifications@github.comwrote:

It is a requirement of celery I believe. The packages in the requirement file have their own requirements. Pip should be able to show you a dependency tree. On Jan 14, 2014 11:16 PM, "Bryan Bonvallet" notifications@github.com wrote:

weird. I just ran an install that I noticed included kombu:

Successfully installed Django django-celery django-compressor Fabric South supervisor oauth2client urllib3 google-api-python-client django-grappelli lxml django-filepicker filemagic fabric-virtualenv requests beautifulsoup4 pyopenssl python-twitter gdshortener html2text django-allauth boto cssmin pylibmc django-storages gunicorn jsmin psycopg2 amqplib django-debug-toolbar ipython ipdb django-extensions django-nose coverage selenium mock django-taggit anyjson indextank pytz celery django-appconf paramiko meld3 httplib2 python-gflags simplejson oauth2 requests-oauthlib python-openid nose billiard python-dateutil kombu six pycrypto ecdsa oauthlib amqp

kombu is not explicitly referred to common.txt, prod.txt, or vmdev.txt, yet there it is. django-kombu was not installed (nor was it requested to be).

what requires kombu in that list?

— Reply to this email directly or view it on GitHub< https://github.com/FinalsClub/karmaworld/issues/276#issuecomment-32333554>

.

— Reply to this email directly or view it on GitHubhttps://github.com/FinalsClub/karmaworld/issues/276#issuecomment-32333871 .

charlesconnell commented 10 years ago

Closing this because it seems that everything is fine.