search

FinalsClub / karmaworld

KarmaNotes.org v3.0
GNU Affero General Public License v3.0
7 stars 6 forks source link

cleanup send_to_s3 using django magic #293

Closed btbonval closed 9 years ago

btbonval commented 10 years ago

It strikes me that python manage.py collectstatic pushes static files to S3 with the correct permissions and all that, but it also works just as well if the static directory is on the local file system.

Perhaps Note.send_to_s3 should be refactored to do whatever collectstatic does, which will make the code cleaner and more portable.

The current stuff is a bit of an ugly boto hack which displeases me. I'm the one who wrote it so I'm not hurting anyone's feelings, either.

If we can remove Note.send_to_s3 and make something more generic like Note.send_to_static, I think the world will be a better place.

btbonval commented 9 years ago

Pretty sure we no longer send notes to S3 any longer.