search

FinalsClub / karmaworld

KarmaNotes.org v3.0
GNU Affero General Public License v3.0
7 stars 6 forks source link

Preserve port number in href tag for footer about link #297

Closed JHilker closed 10 years ago

JHilker commented 10 years ago

No issue for it AFAIK, noticed it on my local dev environment.

btbonval commented 10 years ago

If that works to preserve port, we'll need it in a lot more places. Port is dropped off a ton of URLs in dev-mode. I'll check out the code, thanks!

On Tue, Jan 21, 2014 at 11:51 PM, Jacob Hilker notifications@github.comwrote:

No issue for it AFAIK, noticed it on my local dev environment.

You can merge this Pull Request by running

git pull https://github.com/FinalsClub/karmaworld broken-footer-about-link

Or view, comment on, or merge it at:

https://github.com/FinalsClub/karmaworld/pull/297 Commit Summary

  • Preserve port number in href tag for footer about link

File Changes

  • M karmaworld/templates/footer.htmlhttps://github.com/FinalsClub/karmaworld/pull/297/files#diff-0(2)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/FinalsClub/karmaworld/pull/297 .

btbonval commented 10 years ago

https://github.com/FinalsClub/karmaworld/issues/213

btbonval commented 10 years ago

Looks good. Pulled it in.