btbonval
commented
10 years ago That file could have been left out of the directory entirely or put anywhere. Instead of dropping it in the repo, we can drop it somewhere else. confs is sort of a dumb place, but I wanted to put it somewhere.
I don't want it to be cleaned up. The idea was to cache the file so it doesn't have to be downloaded again.
It's fine to add it to git ignore though. I'll accept the pull request. Also thanks for the spell fix.
On Tue, Jan 21, 2014 at 11:52 PM, Jacob Hilker notifications@github.comwrote:
Charles told me it would be fine to .gitignore this auto generated file created while running the first_deploy task. Another option would be to just clean it up as part of a later task in the script. Preferences?
Also fixed the typo in the file name.
You can merge this Pull Request by running
git pull https://github.com/FinalsClub/karmaworld gitignore-usde-accreditation
Or view, comment on, or merge it at:
https://github.com/FinalsClub/karmaworld/pull/298 Commit Summary
- add accreditation.csv to .gitignore
- fix typo in csv name generation
File Changes
- M .gitignorehttps://github.com/FinalsClub/karmaworld/pull/298/files#diff-0(3)
- M fabfile.pyhttps://github.com/FinalsClub/karmaworld/pull/298/files#diff-1(2)
Patch Links:
- https://github.com/FinalsClub/karmaworld/pull/298.patch
- https://github.com/FinalsClub/karmaworld/pull/298.diff
— Reply to this email directly or view it on GitHubhttps://github.com/FinalsClub/karmaworld/pull/298 .
Charles told me it would be fine to .gitignore this auto generated file created while running the first_deploy task. Another option would be to just clean it up as part of a later task in the script. Preferences?
Also fixed the typo in the file name.