search

FinalsClub / karmaworld

KarmaNotes.org v3.0
GNU Affero General Public License v3.0
7 stars 6 forks source link

Require login to download a note #302

Closed AndrewMagliozzi closed 10 years ago

AndrewMagliozzi commented 10 years ago

Cost downloader 2 karma points

Add 2 karma points to note owner

charlesconnell commented 10 years ago

@AndrewMagliozzi @btbonval Can we get rid of the "Open this note in a new window" link? It's redundant with the download button, and I don't think it looks very good in its current state anyways.

AndrewMagliozzi commented 10 years ago

I have no objections.

On Jan 26, 2014, at 11:39 AM, Charles Connell notifications@github.com wrote:

@AndrewMagliozzi @btbonval Can we get rid of the "Open this note in a new window" link? It's redundant with the download button, and I don't think it looks very good in its current state anyways.

— Reply to this email directly or view it on GitHub.

btbonval commented 10 years ago

Yeah as long as download button does the same thing as that link, no problem at all. On Jan 26, 2014 12:11 PM, "Andrew Magliozzi" notifications@github.com wrote:

I have no objections.

On Jan 26, 2014, at 11:39 AM, Charles Connell notifications@github.com wrote:

@AndrewMagliozzi @btbonval Can we get rid of the "Open this note in a new window" link? It's redundant with the download button, and I don't think it looks very good in its current state anyways.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/FinalsClub/karmaworld/issues/302#issuecomment-33323268 .

charlesconnell commented 10 years ago

Okay that link has been removed, so this ticket is done. As noted in a comment above the link, this helped web crawlers see our content. I'm not sure how well they can read what's inside the note iframe, especially since it's loaded with an ajax request after the page loads. @AndrewMagliozzi There is a feature on Google webmaster tools that allows you to see what the Googlebot will see when it crawls your page. I can't do it since it requires a verified login (proving that I control the site), so I wanted to let you set that up, if you haven't already. I will open a new ticket.

btbonval commented 10 years ago

Yeah I primarily added the "open this link" for web crawlers to index properly. Google supposedly does index IFRAME content somehow, but it was still recommended by SEO to have a proper HREF in there.

As long as the download is a proper HREF, not some javascript hackery, we should be good.

On Sun, Jan 26, 2014 at 4:30 PM, Charles Connell notifications@github.comwrote:

Closed #302 https://github.com/FinalsClub/karmaworld/issues/302.

— Reply to this email directly or view it on GitHubhttps://github.com/FinalsClub/karmaworld/issues/302 .

charlesconnell commented 10 years ago

The download link is a regular href, but it's only there if you're logged in. So crawlers won't see it.

On Sun 26 Jan 2014 04:53:42 PM EST, Bryan Bonvallet wrote:

Yeah I primarily added the "open this link" for web crawlers to index properly. Google supposedly does index IFRAME content somehow, but it was still recommended by SEO to have a proper HREF in there.

As long as the download is a proper HREF, not some javascript hackery, we should be good.

On Sun, Jan 26, 2014 at 4:30 PM, Charles Connell notifications@github.comwrote:

Closed #302 https://github.com/FinalsClub/karmaworld/issues/302.

— Reply to this email directly or view it on GitHubhttps://github.com/FinalsClub/karmaworld/issues/302 .

— Reply to this email directly or view it on GitHub https://github.com/FinalsClub/karmaworld/issues/302#issuecomment-33331754.

btbonval commented 10 years ago

Sorry I commented before I saw there was a more relevant ticket created in

309.