FinalsClub / karmaworld

KarmaNotes.org v3.0

GNU Affero General Public License v3.0

7 stars 6 forks source link

drop plaintext HTTP? #319

Closed btbonval closed 10 years ago

btbonval commented 10 years ago

We have a valid SSL which is already installed and recognized by browsers.

Does it hurt to drop?

can't think of anything, maybe someone else will

Does it hurt to keep?

some code requires SSL to test or access, whereas no code requires non-SSL to test or access.
extra code to handle forwarding between HTTP and HTTPS, such as commit https://github.com/FinalsClub/karmaworld/commit/8ecc45d674be9b5957fb2774c637cb8d86342343
Nonstandard ports on VM will cause forwarding between ports (above) to break
VM needs two ports forwarded instead of just one (more chance of colliding with a port already opened on localhost)

btbonval commented 10 years ago

320 is a direct result of code written to balance both HTTP and HTTPS, a result of the commit noted above.

AndrewMagliozzi commented 10 years ago

If we remove http, the VM will not work, right?

On Feb 6, 2014, at 5:13 AM, Bryan Bonvallet notifications@github.com wrote:

320 is a direct result of code written to balance both HTTP and HTTPS, a result of the commit noted above.

— Reply to this email directly or view it on GitHub.

btbonval commented 10 years ago

VM works fine with HTTPS (at least once I commit #318 , which I'd like to see working first, but there are other issues in the way). Removing HTTP won't hurt the VM after that is commit.

AndrewMagliozzi commented 10 years ago

Great!

On Thu, Feb 6, 2014 at 3:42 PM, Bryan Bonvallet notifications@github.comwrote:

VM works fine with HTTPS (at least once I commit #318https://github.com/FinalsClub/karmaworld/issues/318, which I'd like to see working first, but there are other issues in the way). Removing HTTP won't hurt the VM after that is commit.

Reply to this email directly or view it on GitHubhttps://github.com/FinalsClub/karmaworld/issues/319#issuecomment-34368464 .

charlesconnell commented 10 years ago

+1. I'm going to tear out the redirect stuff inside django.

btbonval commented 10 years ago

Thanks @charlesconnell .

I'll have to fiddle with nginx and the README to reflect this change before the ticket is fully complete.

btbonval commented 10 years ago

Alright, I'll setup a forward rule so HTTP gets redirected to HTTPS via nginx. This is only represented in our code base via README and Vagrantfile, but I have to actually make sure it works on the VM before I can push.

btbonval commented 10 years ago

Blah. Ubuntu servers are going slow, so it took a long time to get the VM up. Had to scrap it twice for nginx fixes. Tested direction via nginx which works fine. Created course logged out and logged in. Will push shortly.

btbonval commented 10 years ago

erm I should update beta and prod with the nginx modifications.

btbonval commented 10 years ago

updated both using the nginx bits from README. beta looks good. prod looks good.

now the ticket can be closed. woo.