search

FinalsClub / karmaworld

KarmaNotes.org v3.0
GNU Affero General Public License v3.0
7 stars 6 forks source link

Weed out more schools #326

Closed btbonval closed 9 years ago

btbonval commented 10 years ago

I'm noticing there are a bunch of barber and nursing schools in my database right now, but I was pretty sure those schools were nuked during upstart.

I need to look into this more to see if it is legit and if so, why is it happening.

AndrewMagliozzi commented 10 years ago

There is definitely a manage.py command to weed out the junk schools. I don't know if it runs on first deploy or not. I think you may have to call it manually.

On Sun, Feb 9, 2014 at 3:03 AM, Bryan Bonvallet notifications@github.comwrote:

I'm noticing there are a bunch of barber and nursing schools in my database right now, but I was pretty sure those schools were nuked during upstart.

I need to look into this more to see if it is legit and if so, why is it happening.

Reply to this email directly or view it on GitHubhttps://github.com/FinalsClub/karmaworld/issues/326 .

btbonval commented 10 years ago

It gets called on first_deploy, I have seen the output. Just have to confirm its doing something. On Feb 9, 2014 11:07 AM, "Andrew Magliozzi" notifications@github.com wrote:

There is definitely a manage.py command to weed out the junk schools. I don't know if it runs on first deploy or not. I think you may have to call it manually.

On Sun, Feb 9, 2014 at 3:03 AM, Bryan Bonvallet <notifications@github.com

wrote:

I'm noticing there are a bunch of barber and nursing schools in my database right now, but I was pretty sure those schools were nuked during upstart.

I need to look into this more to see if it is legit and if so, why is it happening.

Reply to this email directly or view it on GitHub< https://github.com/FinalsClub/karmaworld/issues/326> .

Reply to this email directly or view it on GitHubhttps://github.com/FinalsClub/karmaworld/issues/326#issuecomment-34577609 .

btbonval commented 10 years ago

Possibly related to #252 ?

btbonval commented 10 years ago

We should see if this is still a problem in the Heroku database.

btbonval commented 10 years ago 
dcilk542cqnl8m=> SELECT count(name) FROM courses_school WHERE name ILIKE '% barber %';
 count 
-------
    44
(1 row)
dcilk542cqnl8m=> SELECT count(name) FROM courses_school WHERE name ILIKE '%cosmetic%';
 count 
-------
     4
(1 row)

I just read the script and saw my key words just happened to not be filtered yet: https://github.com/FinalsClub/karmaworld/blob/master/karmaworld/apps/courses/management/commands/sanitize_usde_schools.py#L13-L29

So this ticket is now about adding a few more key words.

Maybe some others.