search

FinalsClub / karmaworld

KarmaNotes.org v3.0
GNU Affero General Public License v3.0
7 stars 6 forks source link

django-taggit, FinalsClub vs Upstream #327

Closed btbonval closed 10 years ago

btbonval commented 10 years ago

We're using a FinalsClub branch of django-taggit.

What has been added? Are there any plans to push the changes upstream? Is there any need to (has upstream already sorted the issue)?

There are a few repos that I have forked and included in reqs, but I'm hoping to get pull requests on all of them.

It might be a good idea to start commenting in reqs with the pull request needed before upstream is suitable.

AndrewMagliozzi commented 10 years ago

Great point, Bryan. @SethWoodworth was the one who forked taggit over a year ago, I believe. I haven't looked at our changes but I'm game to offer a pull request if necessary.

On Feb 9, 2014, at 9:43 PM, Bryan Bonvallet notifications@github.com wrote:

We're using a FinalsClub branch of django-taggit.

What has been added? Are there any plans to push the changes upstream? Is there any need to (has upstream already sorted the issue)?

There are a few repos that I have forked and included in reqs, but I'm hoping to get pull requests on all of them.

It might be a good idea to start commenting in reqs with the pull request needed before upstream is suitable.

— Reply to this email directly or view it on GitHub.

btbonval commented 10 years ago

appears addressed in pull #329

I'd like to confirm one or both of the following before closing the ticket:

  1. changes made to FinalsClub version were pushed upstream, so we can ditch our fork.
  2. the venv was wiped or django-taggit was pip uninstalled prior to trying the upstream version and tested successfully
JHilker commented 10 years ago

I upgraded it since I was using a new feature which was added in the past year. The version we had was a fork of a fork of a fork of a fork. It documented changes were some bugfixes dropped support for Django < 1.3, and a feature we don't use. Seth made no updates to it himself, and our use cases our basic, so I feel like there is no harm in upgrading it to the active repo with commits in the past year. Testing locally it works fine.

I'm currently not running the VM, so I can't test in in specific, but it working locally with an uninstall and reinstall. We can double check when we deploy to beta, but it should be fine.

On Tue, Feb 11, 2014 at 3:59 PM, Bryan Bonvallet notifications@github.comwrote:

appears addressed in pull #329https://github.com/FinalsClub/karmaworld/pull/329

I'd like to confirm one or both of the following before closing the ticket:

  1. changes made to FinalsClub version were pushed upstream, so we can ditch our fork.
  2. the venv was wiped or django-taggit was pip uninstalled prior to trying the upstream version and tested successfully

Reply to this email directly or view it on GitHubhttps://github.com/FinalsClub/karmaworld/issues/327#issuecomment-34806104 .

btbonval commented 10 years ago

You covered point 1 well enough. Works for me. On Feb 11, 2014 5:15 PM, "Jacob Hilker" notifications@github.com wrote:

I upgraded it since I was using a new feature which was added in the past year. The version we had was a fork of a fork of a fork of a fork. It documented changes were some bugfixes dropped support for Django < 1.3, and a feature we don't use. Seth made no updates to it himself, and our use cases our basic, so I feel like there is no harm in upgrading it to the active repo with commits in the past year. Testing locally it works fine.

I'm currently not running the VM, so I can't test in in specific, but it working locally with an uninstall and reinstall. We can double check when we deploy to beta, but it should be fine.

On Tue, Feb 11, 2014 at 3:59 PM, Bryan Bonvallet notifications@github.comwrote:

appears addressed in pull #329< https://github.com/FinalsClub/karmaworld/pull/329>

I'd like to confirm one or both of the following before closing the ticket:

  1. changes made to FinalsClub version were pushed upstream, so we can ditch our fork.
  2. the venv was wiped or django-taggit was pip uninstalled prior to trying the upstream version and tested successfully

Reply to this email directly or view it on GitHub< https://github.com/FinalsClub/karmaworld/issues/327#issuecomment-34806104> .

Reply to this email directly or view it on GitHubhttps://github.com/FinalsClub/karmaworld/issues/327#issuecomment-34814817 .