FinalsClub / karmaworld

KarmaNotes.org v3.0
GNU Affero General Public License v3.0
7 stars 6 forks source link

Tweets are broken #366

Closed charlesconnell closed 10 years ago

charlesconnell commented 10 years ago
[2014-04-16 18:09:06,018: INFO/MainProcess] Got task from broker: tweet_note[75fb7a3b-ccb0-4ca0-b56b-428effbce769]
[2014-04-16 18:09:06,110: ERROR/MainProcess] tweet_note[75fb7a3b-ccb0-4ca0-b56b-428effbce769]: Traceback (most recent call last):
  File "/var/www/karmaworld/karmaworld/apps/notes/tasks.py", line 33, in tweet_note
    update = tweet_string(n)
  File "/var/www/karmaworld/karmaworld/apps/notes/tasks.py", line 52, in tweet_string
    note.get_absolute_url()
  File "/var/www/karmaworld/venv/local/lib/python2.7/site-packages/django/utils/functional.py", line 15, in _curried
    return _curried_func(*(args+moreargs), **dict(kwargs, **morekwargs))
  File "/var/www/karmaworld/venv/local/lib/python2.7/site-packages/django/db/models/base.py", line 985, in get_absolute_url
    return settings.ABSOLUTE_URL_OVERRIDES.get('%s.%s' % (opts.app_label, opts.module_name), func)(self, *args, **kwargs)
  File "/var/www/karmaworld/karmaworld/apps/notes/models.py", line 330, in get_absolute_url
    return reverse('note_detail', args=[self.course.department.school.slug, self.course.slug, self.slug])
AttributeError: 'NoneType' object has no attribute 'school'
AndrewMagliozzi commented 10 years ago

One of our beta testers created a course without selecting a school from the menu. As a result the school id is null.

We should make that school picker force a user to select a school to prevent this (and other) errors.

On Apr 17, 2014, at 8:50 AM, Charles Connell notifications@github.com wrote:

[2014-04-16 18:09:06,018: INFO/MainProcess] Got task from broker: tweet_note[75fb7a3b-ccb0-4ca0-b56b-428effbce769] [2014-04-16 18:09:06,110: ERROR/MainProcess] tweet_note[75fb7a3b-ccb0-4ca0-b56b-428effbce769]: Traceback (most recent call last): File "/var/www/karmaworld/karmaworld/apps/notes/tasks.py", line 33, in tweet_note update = tweet_string(n) File "/var/www/karmaworld/karmaworld/apps/notes/tasks.py", line 52, in tweet_string note.get_absolute_url() File "/var/www/karmaworld/venv/local/lib/python2.7/site-packages/django/utils/functional.py", line 15, in _curried return _curriedfunc((args+moreargs), _dict(kwargs, _morekwargs)) File "/var/www/karmaworld/venv/local/lib/python2.7/site-packages/django/db/models/base.py", line 985, in get_absolute_url return settings.ABSOLUTE_URL_OVERRIDES.get('%s.%s' % (opts.app_label, opts.module_name), func)(self, args, _kwargs) File "/var/www/karmaworld/karmaworld/apps/notes/models.py", line 330, in get_absolute_url return reverse('note_detail', args=[self.course.department.school.slug, self.course.slug, self.slug]) AttributeError: 'NoneType' object has no attribute 'school' — Reply to this email directly or view it on GitHub.

charlesconnell commented 10 years ago

That course has been deleted. I can't duplicate the problem. Closing.